All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] env: allow to export only selected variables
Date: Thu, 17 Nov 2011 20:18:18 +0100	[thread overview]
Message-ID: <20111117191818.EDA4716F44DA@gemini.denx.de> (raw)
In-Reply-To: <4EC55B4F.4060007@keymile.com>

Dear Gerlando Falauto,

In message <4EC55B4F.4060007@keymile.com> you wrote:
> 
> >   ssize_t hexport_r(struct hsearch_data *htab, const char sep,
> > -		 char **resp, size_t size)
> > +		 char **resp, size_t size,
> > +		 int argc, char * const argv[])
> >   {
> >   	ENTRY *list[htab->size];
> >   	char *res, *p;
> 
> What happened to "please indent with TABs only"?
> Have I missed something, perhaps?

Yes, you missed this error in the initial code review :-)

[Unfortunaltely I haven't found yet a way to convince Lindent or
similar to use only TABs in places like that. Hints welcome.]

Please feel free to submit cleanup-patches.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Wenn das dann in die Hose geht, nehme ich es auf meine Kappe.
                                         -- Rudi V?ller, 15. Nov 2003

      reply	other threads:[~2011-11-17 19:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-08 12:22 [U-Boot] [PATCH] env: allow to export only selected variables Wolfgang Denk
2011-11-17 18:47 ` Gerlando Falauto
2011-11-17 19:06 ` Gerlando Falauto
2011-11-17 19:18   ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111117191818.EDA4716F44DA@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.