From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH] r8169: add module param for control of ASPM disable Date: Thu, 17 Nov 2011 21:26:33 +0000 Message-ID: <20111117212633.GA21564@srcf.ucam.org> References: <1321052755-15368-1-git-send-email-tbroch@chromium.org> <20111112045935.GA24292@srcf.ucam.org> <20111112104624.GA24870@electric-eye.fr.zoreil.com> <20111117093724.GB9112@electric-eye.fr.zoreil.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Francois Romieu , Realtek linux nic maintainers , netdev@vger.kernel.org, Hayes Wang To: Todd Broch Return-path: Received: from cavan.codon.org.uk ([93.93.128.6]:35053 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752144Ab1KQV0i (ORCPT ); Thu, 17 Nov 2011 16:26:38 -0500 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Nov 17, 2011 at 01:20:46PM -0800, Todd Broch wrote: > Looking a bit more at the driver a lot of configuration / feature choice is > tied to mac_version. Would this be a better solution (partial patch ... > will submit properly later) I'd be mildly surprised if the mac's the relevant constraint here, although it's possible. This patch is almost certainly safe, but if you're able to check with the hardware vendor you're working with that would be even better. -- Matthew Garrett | mjg59@srcf.ucam.org