From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Thomas Meyer <thomas@m3y3r.de>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86, mrst: Casting (void *) value returned by kmalloc is useless
Date: Fri, 18 Nov 2011 10:16:28 +0000 [thread overview]
Message-ID: <20111118101628.5013a1ea@pyx> (raw)
In-Reply-To: <1321569820.1624.244.camel@localhost.localdomain>
On Thu, 17 Nov 2011 23:43:40 +0100
Thomas Meyer <thomas@m3y3r.de> wrote:
> The semantic patch that makes this change is available
> in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci.
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
>
> diff -u -p a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c
> --- a/arch/x86/platform/mrst/mrst.c 2011-11-07 19:37:40.283168752 +0100
> +++ b/arch/x86/platform/mrst/mrst.c 2011-11-08 09:19:24.686513740 +0100
> @@ -331,7 +331,7 @@ static int __init sfi_parse_gpio(struct
> num = SFI_GET_NUM_ENTRIES(sb, struct sfi_gpio_table_entry);
> pentry = (struct sfi_gpio_table_entry *)sb->pentry;
>
> - gpio_table = (struct sfi_gpio_table_entry *)
> + gpio_table =
> kmalloc(num * sizeof(*pentry), GFP_KERNEL);
True but the formatting also wants fixing with that change.
next prev parent reply other threads:[~2011-11-18 10:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 22:43 [PATCH] x86, mrst: Casting (void *) value returned by kmalloc is useless Thomas Meyer
2011-11-18 10:16 ` Alan Cox [this message]
2011-11-18 13:40 ` Pekka Enberg
2011-11-20 22:28 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111118101628.5013a1ea@pyx \
--to=alan@lxorguk.ukuu.org.uk \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas@m3y3r.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.