From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] drm/i915: add multi-threaded forcewake support Date: Fri, 18 Nov 2011 14:12:03 -0800 Message-ID: <20111118141203.14ddde98@jbarnes-desktop> References: <20111118113632.594717c8@jbarnes-desktop> <86y5vdks4j.fsf@sumi.keithp.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0795938738==" Return-path: Received: from oproxy4-pub.bluehost.com (oproxy4-pub.bluehost.com [69.89.21.11]) by gabe.freedesktop.org (Postfix) with SMTP id CC8C19E794 for ; Fri, 18 Nov 2011 14:11:02 -0800 (PST) In-Reply-To: <86y5vdks4j.fsf@sumi.keithp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Keith Packard Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0795938738== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/ks5dBJMf/27++GU2uqw=qIP"; protocol="application/pgp-signature" --Sig_/ks5dBJMf/27++GU2uqw=qIP Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 18 Nov 2011 14:01:00 -0800 Keith Packard wrote: > On Fri, 18 Nov 2011 11:36:32 -0800, Jesse Barnes wrote: >=20 > > + while (count++ < 50 && (I915_READ_NOTRACE(FORCEWAKE_MT_ACK) & 1)) >=20 > You said this should be << 16 No this one should be looking at the bottom bit, so I think it's ok. >=20 > > + I915_WRITE_NOTRACE(FORCEWAKE_MT, (1<<15) | 1); >=20 > and this should be << 16 too The write needs the mask, and I'm always off by one. :p > > + if (I915_READ(ECOBUS) & FORCEWAKE_MT_ENABLE) { >=20 > ECOBUS (0xa180) is zero on my machine, but I need the new functions. >=20 > Removing the ECOBUS check and switching the shifts to 16 makes this work > on my machine. Cool, hope it'll help others too. Thanks, --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/ks5dBJMf/27++GU2uqw=qIP Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJOxtgzAAoJEIEoDkX4Qk9h2v8P/1CXJy1RAckD8LexLSjSYI2g JcDlf8Sq/0AlQzGDIW872/k1mnfadoqA6GQ5kXd+p6v/kpH2vafmWo8zTlYMCn8/ HmTwG+ib8P8MUyj860yaiMRg5YeUsA3BXbpUhbIbAl+qgw2uxRHgIxw2ZoV2BmmS G9kY95/8UypWlICahonvHuQKjQQAxy2v96XMNhX6LljGBQYjmFW0KScWV6acgQZz ivEZhZQsmDhpjBaJyARHGR5QllHhjb8RWS2mYfIDxCG3kYbLWSVSckQ+XE8KhDU4 aQDamcEWii6ADpbAUW0liAir6wsL/S0aIH6KY+QBE0zTRnAG8cxtHk3Zg5S+nOQ+ D3QaKCU/fQ7OyB2sAKlFBcRBUxMuruFUU0aonPhmt486Bg+vSiETjIIf6dz5MHFx iYQbumCvUK7KM0+s17LXR0BfvTtVdlTewB8ONbsK6c0j/msCNVvW5KMS/a8jQu4q B9Id4uKOSddLW05kK4Xzlw2H61FRJNLijrWOyopa4OUhX5pXvxzXeC/TtGpQ7juO nXjtpeMTJvuf2r9T9H2BSdoc9O8y0QYSIw7KH2TlOIsUY5GiOBLFTR5HgzzJNy+R 1t9i0tiJBuVI9k9H6/sWorOCvGsvchY5at0uUI955okPBzq0n/4hhaTV7K/juTVG g+ocEhrlY8F0q9+kmabw =6lB7 -----END PGP SIGNATURE----- --Sig_/ks5dBJMf/27++GU2uqw=qIP-- --===============0795938738== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0795938738==--