From: "John W. Linville" <linville@tuxdriver.com>
To: Joe Perches <joe@perches.com>
Cc: linux-wireless@vger.kernel.org, Hauke Mehrtens <hauke@hauke-m.de>,
"Luis R. Rodriguez" <lrodriguez@qca.qualcomm.com>
Subject: Re: [PATCH] compat-wireless: avoid pr_fmt build SPAM
Date: Fri, 18 Nov 2011 17:34:46 -0500 [thread overview]
Message-ID: <20111118223445.GA5642@tuxdriver.com> (raw)
In-Reply-To: <1321655181.2367.1.camel@Joe-Laptop>
On Fri, Nov 18, 2011 at 02:26:21PM -0800, Joe Perches wrote:
> On Fri, 2011-11-18 at 15:54 -0500, John W. Linville wrote:
> > The way the compat-* header files are included causes the default
> > pr_fmt definition from <linux/kernel.h> to be evaluated for every file.
> > Files that define pr_fmt then generate a lot of build SPAM about
> > pr_fmt being redefined.
> >
> > Eliminate the build noise by preemptively undefining pr_fmt in those
> > files that define it. This is accomplished by adding a patch to the
> > patches directory.
>
> Why not undef pr_fmt after the compat-* headers?
That caused a build break. IIRC, not everyone that uses pr_*
defines pr_fmt. If pr_fmt is undef'd then they don't compile.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2011-11-18 22:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 20:54 [PATCH] compat-wireless: avoid pr_fmt build SPAM John W. Linville
2011-11-18 21:00 ` Johannes Berg
2011-11-18 21:09 ` John W. Linville
2011-11-18 21:12 ` Luis R. Rodriguez
2011-11-18 21:49 ` John W. Linville
2011-11-18 22:26 ` Joe Perches
2011-11-18 22:34 ` John W. Linville [this message]
2011-11-18 23:03 ` Luis R. Rodriguez
2011-11-18 23:21 ` Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111118223445.GA5642@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=hauke@hauke-m.de \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.