From: Ted Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] e2undo: cast dptr to blk64_t to retrieve block number
Date: Fri, 18 Nov 2011 17:45:57 -0500 [thread overview]
Message-ID: <20111118224557.GB4130@thunk.org> (raw)
In-Reply-To: <4EC44889.7050307@redhat.com>
On Wed, Nov 16, 2011 at 05:34:33PM -0600, Eric Sandeen wrote:
> A 32-bit s390 build was failing on a 64-bit s390x host, when
> make check failed e2undo tests, like this:
>
> md5sum before mke2fs 922c8a591c882dbdd1a381d18547cfd5
> using mke2fs to test e2undo
> Overwriting existing filesystem; this can be undone using the command:
> e2undo /tmp/mke2fs-tmp.EM9XjmTA81.e2undo /tmp/tmp.EM9XjmTA81
>
> md5sum after mke2fs cbf32fb6c3db45280ad013f42ac294f1
> Replayed transaction of size 32768 at location 0
> Replayed transaction of size 32768 at location 0
> Replayed transaction of size 32768 at location 0
> Replayed transaction of size 32768 at location 0
> Replayed transaction of size 0 at location 0
> md5sum after e2undo 31b4e14307c5b7ccce5b8d300c2ad5f1
>
> Note the "at location 0" for the block number.
>
> A proper cast in e2undo.c fixes this up.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2011-11-18 22:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 23:34 [PATCH] e2undo: cast dptr to blk64_t to retrieve block number Eric Sandeen
2011-11-18 22:45 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111118224557.GB4130@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.