From: Jean-Francois Moine <moinejf@free.fr>
To: Ezequiel <elezegarcia@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: Cleanup proposal for media/gspca
Date: Sun, 20 Nov 2011 08:24:29 +0100 [thread overview]
Message-ID: <20111120082429.06ad5a32@tele> (raw)
In-Reply-To: <20111119185950.GB3048@localhost>
On Sat, 19 Nov 2011 15:59:50 -0300
Ezequiel <elezegarcia@gmail.com> wrote:
> Hi Jef,
>
> I just sent a patch to linux-media for this little issue.
>
> I realize it is only a very minor patch,
> so I am not sure If I am helping or just annoying the developers ;)
>
> Anyway, if you could check the patch I would appreciate it.
[snip]
> Again, hope the patch helps,
Hi Ezequiel,
It is not a minor patch, but maybe you don't know about object
programming.
As it is defined, a gspca device _is_ a video device, as a gspca
subdriver is a gspca device, and as a video device is a device: each
lower structure is contained in a higher one.
Your patch defines the gspca structure as a separate entity which is
somewhat related to a video device by two reverse pointers. It
complexifies the structure accesses, adds more code and hides the
nature of a gspca device.
No, your patch does not help...
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
next prev parent reply other threads:[~2011-11-20 7:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111116013445.GA5273@localhost>
2011-11-16 18:19 ` Cleanup proposal for media/gspca Ezequiel García
2011-11-17 10:07 ` Jean-Francois Moine
2011-11-17 18:03 ` Ezequiel
2011-11-19 18:59 ` Ezequiel
2011-11-20 7:24 ` Jean-Francois Moine [this message]
2011-11-21 23:24 ` Ezequiel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111120082429.06ad5a32@tele \
--to=moinejf@free.fr \
--cc=elezegarcia@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.