All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 4 of 4] xenpaging: initial libxl support
Date: Sun, 20 Nov 2011 19:29:51 +0100	[thread overview]
Message-ID: <20111120182951.GA4830@aepfle.de> (raw)
In-Reply-To: <alpine.DEB.2.00.1111071328130.3519@kaball-desktop>

On Mon, Nov 07, Stefano Stabellini wrote:

> On Mon, 7 Nov 2011, Olaf Hering wrote:
> > > If tot_memkb is the pod target of the domain, we should be coherent and
> > > set it equal to target_memkb when paging is inactive.
> > 
> > So far PoD and paging are unrelated and mean different things.
> > I think the difference between max_memkb and tot_memkb could be the
> > trigger to start paging.
> 
> Yes, I think it would be better.

I have to disagree here.

After looking at the code in parse_config_data(), tot_memkb is only set
if actmem= is listed in the configfile. And if actmem= is set, its the
trigger to run xenpaging and let it work toward the specified number.
So checking for a non-null tot_memkb in create_xenpaging() looks like
the correct way to me to decide wether xenpaging should be started.


Olaf

  reply	other threads:[~2011-11-20 18:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-02 14:45 [PATCH 0 of 4] libxl: initial support for xenpaging Olaf Hering
2011-11-02 14:45 ` [PATCH 1 of 4] xenpaging: use guests tot_pages as working target Olaf Hering
2011-11-02 14:45 ` [PATCH 2 of 4] xenpaging: watch the guests memory/target-tot_pages xenstore value Olaf Hering
2011-11-02 14:45 ` [PATCH 3 of 4] xenpaging: add cmdline interface for pager Olaf Hering
2011-11-02 14:45 ` [PATCH 4 of 4] xenpaging: initial libxl support Olaf Hering
2011-11-07 11:02   ` Stefano Stabellini
2011-11-07 12:55     ` Olaf Hering
2011-11-07 13:28       ` Stefano Stabellini
2011-11-20 18:29         ` Olaf Hering [this message]
2011-11-21 10:53           ` Stefano Stabellini
2011-11-21 15:13             ` Olaf Hering
2011-11-21 16:40               ` George Dunlap
2011-11-22  9:05                 ` Ian Campbell
2011-11-22 10:58               ` Stefano Stabellini
2011-11-22 11:22                 ` Olaf Hering
2011-11-22 15:48               ` George Dunlap
2012-01-09 19:21                 ` Olaf Hering
2012-01-10 12:02                   ` George Dunlap
2012-01-11 14:58                     ` Olaf Hering
2012-01-11 16:10                       ` Tim Deegan
2012-01-11 16:38                         ` Olaf Hering
2012-01-11 16:58                           ` Tim Deegan
2012-01-12 14:12                             ` Olaf Hering
2012-01-13 11:00                               ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111120182951.GA4830@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.