From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Mon, 21 Nov 2011 10:54:15 +0100 Subject: [U-Boot] [PATCH 4/4] arm, omap3: Add support for TechNexion modules In-Reply-To: <20111121165205.4624b13b@myhost> References: <20111121165205.4624b13b@myhost> Message-ID: <20111121095415.7620B140876A@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Tapani Utriainen, In message <20111121165205.4624b13b@myhost> you wrote: > > Add support for TechNexion TDM3730 SoM Please use a better Subject: and add a bit more of information to the commit message itself. > Signed-off-by: Tapani Utriainen > CC: Sandeep Paulraj > --- > board/technexion/tdm3730/Makefile | 49 ++++ > board/technexion/tdm3730/tdm3730.c | 173 ++++++++++++++++ > board/technexion/tdm3730/tdm3730.h | 383 +++++++++++++++++++++++++++++++++++++ > boards.cfg | 1 > include/configs/tdm3730.h | 360 ++++++++++++++++++++++++++++++++++ > 5 files changed, 966 insertions(+) Same comments as before, entry to MAINTAINERS missing, etc, etc, > --- /dev/null > +++ b/board/technexion/tdm3730/tdm3730.c > @@ -0,0 +1,173 @@ > +/* > + * TechNexion, > + * > + * Maintainer : > + * Tapani Utriainen This belongs into the MAINTAINERS file. ... > +#define CONFIG_EXTRA_ENV_SETTINGS \ It appears the environment settings on these boards are pretty much similar (which certainly makes sense). Please consider factoring out these common parts into a separate header file instead of repeating them all over. > +#define CONFIG_SYS_INIT_RAM_ADDR 0x4020f800 > +#define CONFIG_SYS_INIT_RAM_SIZE 0x800 Has this been tested? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Time is an illusion perpetrated by the manufacturers of space.