All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH v2 2/2] hwmon: (lm63) Add support for
Date: Mon, 21 Nov 2011 13:48:25 +0000	[thread overview]
Message-ID: <20111121134825.GA1688@ericsson.com> (raw)
In-Reply-To: <1321830618-15817-1-git-send-email-guenter.roeck@ericsson.com>

Hi Jean,

On Mon, Nov 21, 2011 at 08:07:07AM -0500, Jean Delvare wrote:
> On Mon, 21 Nov 2011 10:43:39 +0100, Jean Delvare wrote:
> > What about bit 3 (USF) in this enhanced configuration register? When
> > set, it would affect the way we encode and decode _max and _crit
> > temperature limits, right?
> 
> BTW, if you agree but don't have time to work on this, I would be
> perfectly fine with a check at probe time that would complain (and
> eventually bail out) if the way the chip is configured is not properly
> supported by the driver. If anyone needs the feature, it can be added
> later.
> 
Gives me something to do if I need some distraction ;). It will need
some thinking, so I may choose the complain option for now and submit
a patch later. Bailing out seems a bit harsh - as are temperatures
above 127 C anyway.

Do you remember why you did not add support for the remote temperature
offset registers ?

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2011-11-21 13:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-20 23:10 [lm-sensors] [PATCH v2 2/2] hwmon: (lm63) Add support for LM96163 Guenter Roeck
2011-11-21  9:43 ` [lm-sensors] [PATCH v2 2/2] hwmon: (lm63) Add support for Jean Delvare
2011-11-21 13:07 ` Jean Delvare
2011-11-21 13:11 ` Thierry Reding
2011-11-21 13:48 ` Guenter Roeck [this message]
2011-11-21 16:10 ` Jean Delvare
2011-11-21 16:14 ` Guenter Roeck
2011-11-21 16:47 ` Guenter Roeck
2011-11-21 17:06 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111121134825.GA1688@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.