From: Tejun Heo <tj@kernel.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: rjw@sisk.pl, linux-nfs@vger.kernel.org, linux-pm@vger.kernel.org,
john@calva.com, trond.myklebust@netapp.com
Subject: Re: [PATCH 1/2] sunrpc: make rpc_wait_bit_killable handle freeze events
Date: Mon, 21 Nov 2011 12:42:30 -0800 [thread overview]
Message-ID: <20111121204230.GE25776@google.com> (raw)
In-Reply-To: <20111121204141.GD25776@google.com>
On Mon, Nov 21, 2011 at 12:41:41PM -0800, Tejun Heo wrote:
> Hello, Jeff.
>
> On Mon, Nov 21, 2011 at 03:36:15PM -0500, Jeff Layton wrote:
> > I suppose you're suggesting something like this?
> >
> > freezer_do_not_count();
> > if (!try_to_freeze())
> > schedule();
> > freezer_count();
>
> No,
>
> freezer_do_not_count();
> schedule();
> freezer_count();
> try_to_freeze();
>
> freezer_count() may make %current eligible for freezing again, so it
> has to check whether freezing condition is pending afterwards.
Ooh, freezer_count() already has that. Heh, call me an idiot. The
proposed code seems correct then.
Thanks.
--
tejun
next prev parent reply other threads:[~2011-11-21 20:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 17:40 [PATCH 0/2] nfs/sunrpc: allow freezing of tasks with NFS calls in flight Jeff Layton
2011-11-21 17:40 ` [PATCH 1/2] sunrpc: make rpc_wait_bit_killable handle freeze events Jeff Layton
2011-11-21 17:56 ` Tejun Heo
2011-11-21 20:36 ` Jeff Layton
2011-11-21 20:41 ` Tejun Heo
2011-11-21 20:42 ` Tejun Heo [this message]
2011-11-21 20:46 ` Tejun Heo
2011-11-21 20:57 ` Jeff Layton
2011-11-21 17:40 ` [PATCH 2/2] nfs: make TASK_KILLABLE sleeps attempt to freeze Jeff Layton
-- strict thread matches above, loose matches on Subject: below --
2011-10-28 6:08 [PATCH 1/2] sunrpc: make rpc_wait_bit_killable handle freeze events Jeff Layton
2011-10-28 6:08 Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111121204230.GE25776@google.com \
--to=tj@kernel.org \
--cc=jlayton@redhat.com \
--cc=john@calva.com \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=trond.myklebust@netapp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.