From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH] cgroup_freezer: fix freezing groups with stopped tasks Date: Mon, 21 Nov 2011 15:07:09 -0800 Message-ID: <20111121230709.GR25776@google.com> References: <1321480234-29241-1-git-send-email-mhocko@suse.cz> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=YI8sbwiDh8nStCsPbEiXW4FsCA2HmqqXV9qdHqQabD4=; b=qMA82i8bNFc4GJHzA0s3tbT+TfI73cfQEXysT8ZrcvcvJJ3SjNGAfTUqeGqZa+mUxZ qVdOtferYlycn+GjGpl31AticvTiym62iol/iOqfquzt8NjmcDDONzp7WadAjSQmyyQr yM7RKy4RKoU826Ls+ZGRWCrSI8/kZtu9nkN7M= Content-Disposition: inline In-Reply-To: <1321480234-29241-1-git-send-email-mhocko-AlSwsSmVLrQ@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michal Hocko Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Tomasz Buchert , Paul Menage , Li Zefan , Andrew Morton Hello, Michal. On Wed, Nov 16, 2011 at 10:50:34PM +0100, Michal Hocko wrote: > +/* Task is frozen or will freeze immediately when next it gets woken */ > +static bool is_task_frozen_enough(struct task_struct *task) > +{ > + return frozen(task) || > + (task_is_stopped_or_traced(task) && freezing(task)); > +} Hmmm... w/ pending freezer updates, the above would always return %true if there's freezing in progress, which can't be right. Maybe just test stopped/traced? http://git.kernel.org/?p=linux/kernel/git/tj/misc.git;a=shortlog;h=refs/heads/pm-freezer Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754482Ab1KUXHQ (ORCPT ); Mon, 21 Nov 2011 18:07:16 -0500 Received: from mail-iy0-f174.google.com ([209.85.210.174]:64555 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752765Ab1KUXHO (ORCPT ); Mon, 21 Nov 2011 18:07:14 -0500 Date: Mon, 21 Nov 2011 15:07:09 -0800 From: Tejun Heo To: Michal Hocko Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, containers@lists.linux-foundation.org, Tomasz Buchert , Paul Menage , Li Zefan , Andrew Morton Subject: Re: [PATCH] cgroup_freezer: fix freezing groups with stopped tasks Message-ID: <20111121230709.GR25776@google.com> References: <1321480234-29241-1-git-send-email-mhocko@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1321480234-29241-1-git-send-email-mhocko@suse.cz> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Michal. On Wed, Nov 16, 2011 at 10:50:34PM +0100, Michal Hocko wrote: > +/* Task is frozen or will freeze immediately when next it gets woken */ > +static bool is_task_frozen_enough(struct task_struct *task) > +{ > + return frozen(task) || > + (task_is_stopped_or_traced(task) && freezing(task)); > +} Hmmm... w/ pending freezer updates, the above would always return %true if there's freezing in progress, which can't be right. Maybe just test stopped/traced? http://git.kernel.org/?p=linux/kernel/git/tj/misc.git;a=shortlog;h=refs/heads/pm-freezer Thanks. -- tejun