From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanislaw Gruszka Subject: Re: linux-next: build warning after merge of the wireless-next tree Date: Tue, 22 Nov 2011 08:56:41 +0100 Message-ID: <20111122075640.GB2199@redhat.com> References: <20111122142502.ca68d0a1640b2a8480d51ad2@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx1.redhat.com ([209.132.183.28]:43356 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752152Ab1KVHyi (ORCPT ); Tue, 22 Nov 2011 02:54:38 -0500 Content-Disposition: inline In-Reply-To: <20111122142502.ca68d0a1640b2a8480d51ad2@canb.auug.org.au> Sender: linux-next-owner@vger.kernel.org List-ID: To: Stephen Rothwell Cc: "John W. Linville" , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Gortmaker On Tue, Nov 22, 2011 at 02:25:02PM +1100, Stephen Rothwell wrote: > After merging the wireless-next tree, today's linux-next build > (x86_64_allmodconfig) produced this warning: > > drivers/net/wireless/iwlegacy/debug.c:1395:1: warning: data definition has no type or storage class [enabled by default] > drivers/net/wireless/iwlegacy/debug.c:1395:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int] > drivers/net/wireless/iwlegacy/debug.c:1395:1: warning: parameter names (without types) in function declaration [enabled by default] > drivers/net/wireless/iwlegacy/debug.c:1410:1: warning: data definition has no type or storage class [enabled by default] > drivers/net/wireless/iwlegacy/debug.c:1410:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' [-Wimplicit-int] > drivers/net/wireless/iwlegacy/debug.c:1410:1: warning: parameter names (without types) in function declaration [enabled by default] > > This indicates that this file needs to include export.h. I think adding export.h to debug.c should be part of current wireless-next manual merge (debug.c include old iwl-debugfs.c, which was modified with export.h). If not, I'm posting patch with fix in the following email. Thanks Stanislaw