Re: [RFC][PATCH 0/3] fork: Add the ability to create tasks with given pids

[Tejun Heo <tj@kernel.org>]

Hello,

On Tue, Nov 22, 2011 at 03:11:02PM +0400, Pavel Emelyanov wrote:
> > Hmmm... I hope this could be prettier.  I'm having trouble following
> > where the MAY_OPEN comes from.  Can you please explain?
> 
> From this calltrace:
> 
>  pid_ns_ctl_permissions
>  sysctl_perm
>  proc_sys_permission
>  inode_permission
>  do_last <<<<< MAY_OPEN appears here
>  path_openat
>  do_filp_open
>  do_sys_open
>  sys_open

Thanks a lot. :)

> > Can't we for now allow this for root and then later allow CAP_CHECKPOINT 
> > that Cyrill suggested?  Or do we want to allow setting pids even w/o CR 
> > for NS creator?
> 
> I think that systemd guys can play with it. E.g. respawning daemons with predefined
> pids sounds like an interesting thing to play with.

But wouldn't CAP_CHECKPOINT be enough for systemd?

> >> +static int pid_ns_ctl_handler(struct ctl_table *table, int write,
> >> +		     void __user *buffer, size_t *lenp, loff_t *ppos)
> >> +{
> >> +	struct ctl_table tmp = *table;
> >> +	tmp.data = &current->nsproxy->pid_ns->last_pid;
> >> +	return proc_dointvec(&tmp, write, buffer, lenp, ppos);
> >> +}
> > 
> > Probably better to call set_last_pid() on write path instead?
> 
> Why? The usage of this sysctl is going to be synchronized  by external locks,
> so why should we care?

I think the question should usually be the other way around.  Why
deviate when the deviation doesn't earn any tangible benefit?  If you
think setting it explicitly is justified, explain why in the comment
of the setter and places where those explicit settings are.

Thanks.

-- 
tejun