All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] M28: Fix OB1 bug in GPIO driver
Date: Tue, 22 Nov 2011 19:14:48 +0100	[thread overview]
Message-ID: <201111221914.48941.marek.vasut@gmail.com> (raw)
In-Reply-To: <B0658F55E67EDE4A914644632835B2CAF7E57B@DEUTERIUM.delien.local>

> This patch fixes a small off-by-one bug in the GPIO driver for the mxs
> platform that allowed the selection gpio pins of one bank more than the
> SoC actually has.
> 
> Signed-off-by: Robert Deli?n <robert@delien.nl>
> 
> diff --git a/drivers/gpio/mxs_gpio.c b/drivers/gpio/mxs_gpio.c
> index b7e9591..539738b 100644
> --- a/drivers/gpio/mxs_gpio.c
> +++ b/drivers/gpio/mxs_gpio.c
> @@ -120,7 +120,7 @@ int gpio_direction_output(int gp, int value)
> 
>  int gpio_request(int gp, const char *label)
>  {
> -       if (PAD_BANK(gp) > PINCTRL_BANKS)
> +       if (PAD_BANK(gp) >= PINCTRL_BANKS)
>                 return -EINVAL;
> 
>         return 0;

Acked-by: Marek Vasut <marek.vasut@gmail.com>

I'd like to see Stefano review this too.

M

  parent reply	other threads:[~2011-11-22 18:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-22 14:14 [U-Boot] [PATCH] M28: Fix OB1 bug in GPIO driver Robert Deliën
2011-11-22 14:21 ` Marek Vasut
2011-11-22 18:14 ` Marek Vasut [this message]
     [not found] ` <201111221953.42597.marek.vasut@gmail.com>
     [not found]   ` <0691ADAF-BBB6-4B35-A26B-BDAF622ED9D2@delien.nl>
2011-11-22 22:35     ` Marek Vasut
2011-11-22 22:49 ` Marek Vasut
2011-11-25  8:14 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201111221914.48941.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.