From: Matthew Garrett <mjg@redhat.com>
To: Keith Packard <keithp@keithp.com>
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: By default, enable RC6 on IVB and SNB when reasonable
Date: Tue, 22 Nov 2011 20:15:31 +0000 [thread overview]
Message-ID: <20111122201531.GD5547@srcf.ucam.org> (raw)
In-Reply-To: <1321684889-18691-1-git-send-email-keithp@keithp.com>
On Fri, Nov 18, 2011 at 10:41:29PM -0800, Keith Packard wrote:
> + /*
> + * Only enable RC6 if all dma remapping is disabled, or if
> + * there's no iommu present in the machine.
> + */
> + if (INTEL_INFO(dev)->gen == 6)
> + return no_iommu || dmar_disabled;
So the user has to choose between 5W of power saving or having dmar? And
we default to giving them dmar? I think that's going to come as a
surprise to people.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-11-22 20:15 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 18:15 [PATCH 0/8] misc fixes for 3.2 Eugeni Dodonov
2011-11-28 18:15 ` [PATCH 1/8] drm/i915: there is no pipe CxSR on ironlake Eugeni Dodonov
2011-11-28 18:15 ` [PATCH 2/8] drm: give up on edid retries when i2c bus is not responding Eugeni Dodonov
2011-11-28 18:15 ` [PATCH 3/8] drm/i915: prevent division by zero when asking for chipset power Eugeni Dodonov
2011-11-28 18:15 ` [PATCH 4/8] drm/i915: fix typo in function name Eugeni Dodonov
2012-01-16 22:26 ` Daniel Vetter
2011-11-28 18:15 ` [PATCH 5/8] platform/x86: fix typos in function comments Eugeni Dodonov
2011-11-28 18:15 ` [PATCH 6/8] drm/i915: enable semaphores on per-device defaults Eugeni Dodonov
2011-11-28 18:45 ` Daniel Vetter
2011-12-10 0:02 ` Keith Packard
2011-12-10 1:05 ` [PATCH] " Eugeni Dodonov
2011-11-28 18:15 ` [PATCH 7/8] drm/i915: allow per-device fbc to work with default settings Eugeni Dodonov
2011-11-28 18:15 ` [PATCH 8/8] drm/i915: enable rc6 by default on IVB onwards Eugeni Dodonov
2011-11-28 19:05 ` Daniel Vetter
2011-11-29 0:24 ` [PATCH] " Eugeni Dodonov
2011-11-19 6:41 ` [PATCH] drm/i915: By default, enable RC6 on IVB and SNB when reasonable Keith Packard
2011-11-19 7:37 ` Kenneth Graunke
2011-11-19 7:37 ` [Intel-gfx] " Kenneth Graunke
2011-11-19 9:07 ` Eugeni Dodonov
2011-11-19 9:25 ` Eugeni Dodonov
2011-11-19 18:32 ` Keith Packard
2011-11-20 21:19 ` Eugeni Dodonov
2011-11-22 20:15 ` Matthew Garrett [this message]
2011-11-22 20:46 ` Eugeni Dodonov
2011-11-22 20:51 ` Matthew Garrett
2011-11-23 3:31 ` Keith Packard
2011-11-23 3:31 ` Keith Packard
2011-11-23 10:26 ` Daniel Vetter
2011-11-23 14:01 ` David Woodhouse
2011-11-23 14:39 ` Daniel Vetter
2011-11-23 14:39 ` Daniel Vetter
2011-11-23 15:03 ` David Woodhouse
2011-11-23 15:31 ` Daniel Vetter
2011-11-23 15:36 ` David Woodhouse
2011-11-23 15:46 ` Daniel Vetter
2011-11-23 15:41 ` Daniel Vetter
2011-11-23 15:43 ` David Woodhouse
2011-11-23 20:35 ` Daniel Vetter
2011-11-23 18:42 ` [PATCH] iommu: export no_iommu and dmar_disabled symbols Eugeni Dodonov
2011-11-23 20:36 ` [Intel-gfx] " David Woodhouse
2011-11-23 20:48 ` Keith Packard
2011-12-09 23:53 ` drm/i915: Enabling RC6 where possible Keith Packard
2011-12-09 23:53 ` [PATCH 1/2] iommu: Export intel_iommu_enabled to signal when iommu is in use Keith Packard
2011-12-09 23:53 ` [PATCH 2/2] drm/i915: By default, enable RC6 on IVB and SNB when reasonable Keith Packard
2011-12-13 3:45 ` Matthew Garrett
2011-11-29 0:30 ` [PATCH] drm/i915: enable rc6 by default on IVB onwards Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111122201531.GD5547@srcf.ucam.org \
--to=mjg@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.