From: "John W. Linville" <linville@tuxdriver.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: David Miller <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: pull request: wireless 2011-11-22
Date: Tue, 22 Nov 2011 16:44:39 -0500 [thread overview]
Message-ID: <20111122214438.GG8452@tuxdriver.com> (raw)
In-Reply-To: <4ECC1479.8090209@lwfinger.net>
On Tue, Nov 22, 2011 at 03:30:33PM -0600, Larry Finger wrote:
> On 11/22/2011 03:13 PM, David Miller wrote:
> >From: David Miller<davem@davemloft.net>
> >Date: Tue, 22 Nov 2011 16:05:11 -0500 (EST)
> >Everyone can just return IRQ_HANDLED and everything would just work.
> >
> >But you know that's not the case, and that it's important that this value
> >is returned accurately.
>
> I was trying to find the thread that reported the improvement in
> performance with this change, but failed. Is it possible that their
> change just papered over an interrupt storm from some other device
> that shared that interrupt?
Original patch was posted here:
http://marc.info/?l=linux-wireless&m=132143811916674&w=2
And the Red Hat Bugzilla entry is here:
https://bugzilla.redhat.com/show_bug.cgi?id=658451
> I'm following this because the rtlwifi-family of drivers already did
> what was suggested here. If this is wrong, then so is it.
Sounds like that nees to be fixed...
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2011-11-22 21:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 19:35 pull request: wireless 2011-11-22 John W. Linville
2011-11-22 20:14 ` David Miller
2011-11-22 20:56 ` John W. Linville
2011-11-22 21:05 ` David Miller
2011-11-22 21:13 ` David Miller
2011-11-22 21:26 ` John W. Linville
2011-11-22 21:30 ` Larry Finger
2011-11-22 21:40 ` David Miller
2011-11-23 8:03 ` Stanislaw Gruszka
2011-11-23 8:57 ` David Miller
2011-11-22 21:44 ` John W. Linville [this message]
2011-11-22 21:56 ` pull request: wireless 2011-11-22 #2 John W. Linville
2011-11-22 22:37 ` David Miller
2011-11-22 22:41 ` John W. Linville
2011-11-22 23:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111122214438.GG8452@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=Larry.Finger@lwfinger.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.