All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@enac.fr>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Henrik Rydberg <rydberg@euromail.se>,
	Jiri Kosina <jkosina@suse.cz>,
	Stephane Chatty <chatty@lii-enac.fr>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/8] HID-multitouch: Add egalax ID for Acer Iconia W500
Date: Wed, 23 Nov 2011 11:46:51 +0100	[thread overview]
Message-ID: <201111231146.51325.marek.vasut@gmail.com> (raw)
In-Reply-To: <1322042074-3759-7-git-send-email-benjamin.tissoires@enac.fr>

> From: Marek Vasut <marek.vasut@gmail.com>
> 
> This patch adds USB ID for the touchpanel in Acer Iconia W500. The panel
> supports up to five fingers, therefore the need for a new addition of panel
> types.
> 
> originally Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> CC: Marek Vasut <marek.vasut@gmail.com>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@enac.fr>
> ---
>  drivers/hid/hid-core.c       |    1 +
>  drivers/hid/hid-ids.h        |    1 +
>  drivers/hid/hid-multitouch.c |    3 +++
>  3 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index b776bfb..e3c9e61 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -1409,6 +1409,7 @@ static const struct hid_device_id
> hid_have_special_driver[] = { { HID_USB_DEVICE(USB_VENDOR_ID_DWAV,
> USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_720C) }, {
> HID_USB_DEVICE(USB_VENDOR_ID_DWAV,
> USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_726B) }, {
> HID_USB_DEVICE(USB_VENDOR_ID_DWAV,
> USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_72A1) }, +	{
> HID_USB_DEVICE(USB_VENDOR_ID_DWAV,
> USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7302) }, {
> HID_USB_DEVICE(USB_VENDOR_ID_DWAV,
> USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_A001) }, {
> HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_ELECOM, USB_DEVICE_ID_ELECOM_BM084) },
> { HID_USB_DEVICE(USB_VENDOR_ID_ELO, USB_DEVICE_ID_ELO_TS2515) }, diff
> --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index a9526fd..fc49ab3 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -235,6 +235,7 @@
>  #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_720C	0x720c
>  #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_726B	0x726b
>  #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_72A1	0x72a1
> +#define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7302	0x7302
>  #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_A001	0xa001
> 
>  #define USB_VENDOR_ID_ELECOM		0x056e
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index db39228..8e920cd 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -701,6 +701,9 @@ static const struct hid_device_id mt_devices[] = {
>  			USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_72A1) },
>  	{ .driver_data = MT_CLS_EGALAX,
>  		HID_USB_DEVICE(USB_VENDOR_ID_DWAV,
> +			USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7302) },
> +	{ .driver_data = MT_CLS_EGALAX,
> +		HID_USB_DEVICE(USB_VENDOR_ID_DWAV,
>  			USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_A001) },
> 
>  	/* Elo TouchSystems IntelliTouch Plus panel */

It seems good, but how do you detect the number of fingers the panel can handle? 
That's autodetected now?

M

  reply	other threads:[~2011-11-23 10:46 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-23  9:54 [PATCH 0/8] multitouch updates (mainly eGalax) Benjamin Tissoires
2011-11-23  9:54 ` [PATCH 1/8] HID: hid-multitouch - add another eGalax id Benjamin Tissoires
2011-11-23  9:54 ` [PATCH 2/8] hid-multitouch: create sysfs attribute to control quirks from user-space Benjamin Tissoires
2011-11-23  9:54 ` [PATCH 3/8] hid-multitouch: cleanup eGalax quirks Benjamin Tissoires
2011-11-23  9:54 ` [PATCH 4/8] hid-multitouch: remove .maxcontacts field for eGalax Benjamin Tissoires
2011-11-23  9:54 ` [PATCH 5/8] HID: cleanup with eGalax PID definitions Benjamin Tissoires
2011-11-23  9:54 ` [PATCH 6/8] HID-multitouch: Add egalax ID for Acer Iconia W500 Benjamin Tissoires
2011-11-23 10:46   ` Marek Vasut [this message]
2011-11-23 11:32     ` Benjamin Tissoires
2011-11-23 11:32       ` Benjamin Tissoires
2011-11-23 11:28   ` Jiri Kosina
2011-11-23 11:36     ` Benjamin Tissoires
2011-11-23 11:36       ` Benjamin Tissoires
2011-11-23 12:10       ` Marek Vasut
2011-11-23  9:54 ` [PATCH 7/8] hid-multitouch: add support for the MSI Windpad 110W Benjamin Tissoires
2011-11-23  9:54 ` [PATCH 8/8] hid-multitouch: correct eGalax a001 protocol Benjamin Tissoires
2011-11-23 18:20   ` Chris Bagwell
2011-11-23 18:20     ` Chris Bagwell
2011-11-23 12:49 ` [PATCH 0/8] multitouch updates (mainly eGalax) Jiri Kosina
2011-11-23 13:14   ` Benjamin Tissoires
2011-11-23 13:14     ` Benjamin Tissoires
2011-11-29  8:56 ` Henrik Rydberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201111231146.51325.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=benjamin.tissoires@enac.fr \
    --cc=chatty@lii-enac.fr \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rydberg@euromail.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.