Re: [PATCH RFC] watchdog: add a new driver for VIA chipsets

[Dmitry Artamonow <mad_soft@inbox.ru>]

On 19:55 Tue 22 Nov     , Marc Vertes wrote:
> Add a new driver for the hardware watchdog timer on VIA chipsets.
> This driver uses the new watchdog framework.
> Tested on a Artigo A1100, VX855 chipset.
> 
> Signed-off-by: Marc Vertes <marc.vertes@sigfox.com>
> ---

[ .... ]

> +obj-$(CONFIG_VIA_WDT) += via_wdt.o

"via_wdt" seems to be a too generic name. What if someone will want to
write driver for some incompatible watchdog also made by VIA?
Maybe it's worth to use something more specific - say, "via_vx8xx_wdt"?


> + *
> + * The only way to activate the watchdog timer or to set its period is
> + * through BIOS setup.
> + */

Why is to rely on BIOS setup? Is there really no information on what
registers to write to start watchdog? Or you was just lazy to find it?
It took me less than a minute to google up a datasheet[1] on VX800/VX820
and it seems to have all needed information to implement proper start()
and stop() functions. I suppose info on watchdog registers should be
applicable to VX855 as well - but it's better to check on your hardware
anyway.

[1] http://linux.via.com.tw/support/beginDownload.action?eleid=161&fid=241

-- 
Best regards,
Dmitry "MAD" Artamonow