All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: "Luis R. Rodriguez" <mcgrof@qca.qualcomm.com>
Cc: Timo Lindhorst <tlnd@online.de>,
	johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] cfg80211: Fix changing regulatory from userspace
Date: Wed, 23 Nov 2011 09:42:59 -0500	[thread overview]
Message-ID: <20111123144258.GC2502@tuxdriver.com> (raw)
In-Reply-To: <20111123143456.GB2502@tuxdriver.com>

On Wed, Nov 23, 2011 at 09:34:56AM -0500, John W. Linville wrote:
> On Wed, Nov 23, 2011 at 06:28:57AM -0800, Luis R. Rodriguez wrote:
> > On Tue, Nov 22, 2011 at 6:30 PM, Timo Lindhorst <tlnd@online.de> wrote:
> > > The commit de3584bd62d87b4c250129fbc46ca52c80330add -
> > > "cfg80211: fix regulatory NULL dereference" prevents the regulatory
> > > domain from being changed by user space. A wiphy is only present
> > > if the request comes from driver or is set by country IE, thus
> > > check only those cases.
> > >
> > > Signed-off-by: Timo Lindhorst <tlnd@online.de>
> > 
> > Yup but at this point I'd prefer we revert the original patch instead
> > given that the patch also had some other short comings. John is it too
> > late?
> 
> No, it isn't too late to revert it.  But can we have a new fix soon?

Hmmm...actually, the original patch was sent in the batch yesterday.
And it was Cc: stable.  It would be a lot less confusing to merge a
correct fix on top (and Cc: stable on that too).  What is wrong with
this one?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

  reply	other threads:[~2011-11-23 14:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-23  2:30 [PATCH] cfg80211: Fix changing regulatory from userspace Timo Lindhorst
2011-11-23 14:28 ` Luis R. Rodriguez
2011-11-23 14:34   ` John W. Linville
2011-11-23 14:42     ` John W. Linville [this message]
2011-11-23 14:58       ` Luis R. Rodriguez
2011-11-28 18:45         ` John W. Linville
2011-11-28 19:14           ` Luis R. Rodriguez
2011-11-29  8:32             ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111123144258.GC2502@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mcgrof@qca.qualcomm.com \
    --cc=tlnd@online.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.