From: Tejun Heo <tj@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>, Jiri Olsa <jolsa@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] trace_event_filter: factorize filter creation
Date: Wed, 23 Nov 2011 07:59:52 -0800 [thread overview]
Message-ID: <20111123155952.GA25780@google.com> (raw)
In-Reply-To: <1322061561.20742.53.camel@frodo>
Hello,
On Wed, Nov 23, 2011 at 10:19:21AM -0500, Steven Rostedt wrote:
> For such a change, I would have liked to see more deletions than
> insertions. Although, if it removes duplicate code, I'm not against such
> a change.
Yeah, certainly. If you count out the function comments, it reduces
~30 lines of code. I was trying to add another user and with one more
user, the stats become more attractive.
> I'll look at this more when I get some more time. But just in
> case I forget about it (because I wont look at it before my turkey
> dinner tomorrow, and will most likely forget about it come next Monday),
> please feel free to ping me again next week.
Will do so.
Thank you.
--
tejun
next prev parent reply other threads:[~2011-11-23 16:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 1:46 [PATCH 1/2] trace_events_filter: use rcu_assign_pointer() when setting ftrace_event_call->filter Tejun Heo
2011-11-23 2:00 ` [PATCH 2/2] trace_event_filter: factorize filter creation Tejun Heo
2011-11-23 15:19 ` Steven Rostedt
2011-11-23 15:59 ` Tejun Heo [this message]
2011-11-28 20:49 ` Tejun Heo
2011-11-28 22:15 ` Steven Rostedt
2011-12-08 23:32 ` Tejun Heo
2011-12-09 0:15 ` Steven Rostedt
2011-12-09 0:46 ` Steven Rostedt
2011-12-09 18:55 ` Tejun Heo
2011-12-09 19:43 ` [PATCH 2/2 UPDATED] " Tejun Heo
2011-11-23 15:16 ` [PATCH 1/2] trace_events_filter: use rcu_assign_pointer() when setting ftrace_event_call->filter Steven Rostedt
2011-11-23 16:06 ` Tejun Heo
2011-11-23 16:12 ` Tejun Heo
2011-11-23 17:06 ` Steven Rostedt
2011-11-23 17:33 ` Tejun Heo
2011-11-28 16:49 ` Paul E. McKenney
2011-11-23 16:40 ` Eric Dumazet
2011-11-23 16:44 ` Tejun Heo
2011-11-23 16:49 ` [PATCH UPDATED " Tejun Heo
2011-12-05 17:34 ` [tip:perf/urgent] trace_events_filter: Use " tip-bot for Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111123155952.GA25780@google.com \
--to=tj@kernel.org \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.