All of lore.kernel.org
 help / color / mirror / Atom feed
From: willy@linux.intel.com (Matthew Wilcox)
Subject: submission queue and completion queue allocation in NVMe
Date: Wed, 23 Nov 2011 15:50:52 -0500	[thread overview]
Message-ID: <20111123205052.GA14291@linux.intel.com> (raw)
In-Reply-To: <5AC4D6A45304E048A30F105EB302760902CBB066@CORPEXCH1.na.ads.idt.com>

On Wed, Nov 23, 2011@10:17:19AM -0800, Kong, Kwok wrote:
> Matthew,
> 
> In the current linux driver, you send a Get Feature with Feature ID = 7
> (Number of Queues) to allocate submission and completion queues from the
> controller.
> 
> My understanding is that you should use Set Feature with Feature ID = 7
> to allocate submission and completion queues from the controller.  The
> Get Feature with ID = 7 returns the number of queues that have been
> allocated.
> 
> If you send a Get Feature with ID =7 without first sending a Set Feature
> with ID =7, the Get feature should return 0 in Dword 0 as no queues have
> been allocated.
> 
> Do you agree ?

That wasn't my understanding ... but 7.6.1 says I was incorrect.

If I just change the call to be nvme_admin_set_features instead of
get_features, that's sufficient, right?  I don't need to issue a Set
Features and then a Get Features to find out what was set.

  reply	other threads:[~2011-11-23 20:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-23 18:17 submission queue and completion queue allocation in NVMe Kong, Kwok
2011-11-23 20:50 ` Matthew Wilcox [this message]
2011-11-23 21:21   ` Kong, Kwok

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111123205052.GA14291@linux.intel.com \
    --to=willy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.