From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Linux PM list <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Randy Dunlap <rdunlap@xenotime.net>,
Ming Lei <tom.leiming@gmail.com>
Subject: Re: [PATCH 5] PM: Update comments describing device power management callbacks
Date: Wed, 23 Nov 2011 21:01:35 +0100 [thread overview]
Message-ID: <201111232101.36188.rjw@sisk.pl> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1111231127370.2111-100000@iolanthe.rowland.org>
On Wednesday, November 23, 2011, Alan Stern wrote:
> On Wed, 23 Nov 2011, Rafael J. Wysocki wrote:
>
> > On Tuesday, November 22, 2011, Alan Stern wrote:
> > > On Tue, 22 Nov 2011, Rafael J. Wysocki wrote:
> > >
> > > > > The same data structure (dev_pm_ops) is used for both drivers and
> > > > > subsystems. Therefore the comments should be directed toward both
> > > > > driver writers and subsystem writers.
> > > >
> > > > I don't quite agree. Trying to do so would turn that comment into a lengthy
> > > > document and there's no room for anything like that in the header file.
> > >
> > > That's a good point.
> > >
> > > > Perhaps I'll just modify the comment to say when the callbacks are executed
> > > > without specifying what the specific callbacks are supposed to do (because
> > > > that may vary from one subsystem to another and even between different
> > > > drivers belonging to the same subsystem). If PM domains are taken into
> > > > account, it gets even more complicated.
> > >
> > > Yes, a minimal description would be good, along with a pointer to the
> > > Documentation/power files.
> >
> > Well, the one below is not exactly minimal, but I think it doesn't go too
> > far at least.
>
> Yes, I like this version better.
Great, thanks!
Rafael
next prev parent reply other threads:[~2011-11-23 19:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-20 0:53 [PATCH 0/3] PM: Documentation updates Rafael J. Wysocki
2011-11-20 0:54 ` [PATCH 1/3] PM / Domains: Document how PM domains are used by the PM core Rafael J. Wysocki
2011-11-20 0:56 ` [PATCH 2/3] PM / Sleep: Correct inaccurate information in devices.txt Rafael J. Wysocki
2011-11-20 0:56 ` [PATCH 3/3] PM / Runtime: Make documentation follow the new behavior of irq_safe Rafael J. Wysocki
2011-11-20 10:13 ` [PATCH 4] Rafael J. Wysocki
2011-11-20 23:38 ` [PATCH 5] PM: Update comments describing device power management callbacks Rafael J. Wysocki
2011-11-21 2:56 ` Alan Stern
2011-11-21 20:02 ` Rafael J. Wysocki
2011-11-21 21:03 ` Alan Stern
2011-11-21 21:23 ` Rafael J. Wysocki
2011-11-21 21:49 ` Alan Stern
2011-11-21 21:57 ` Rafael J. Wysocki
2011-11-21 22:23 ` Alan Stern
2011-11-21 22:33 ` Rafael J. Wysocki
2011-11-22 15:57 ` Alan Stern
2011-11-22 20:47 ` Rafael J. Wysocki
2011-11-22 21:02 ` Alan Stern
2011-11-22 23:40 ` Rafael J. Wysocki
2011-11-23 16:28 ` Alan Stern
2011-11-23 20:01 ` Rafael J. Wysocki [this message]
2011-11-22 3:36 ` Ming Lei
2011-11-22 20:41 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111232101.36188.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=stern@rowland.harvard.edu \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.