All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "Björn JACKE" <bj-3ekOc4rQMZmzQB+pC5nmwQ@public.gmane.org>,
	piastry-7qunaywFIewox3rIn2DAYQ@public.gmane.org,
	phireph0x-/E1597aS9LQAvxtiuMwx3w@public.gmane.org,
	linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] cifs: lower default wsize when unix extensions are not used
Date: Thu, 24 Nov 2011 07:20:36 -0500	[thread overview]
Message-ID: <20111124072036.0fa2ad0d@corrin.poochiereds.net> (raw)
In-Reply-To: <CAH2r5muKFRup1BwPqGuiy=+kh-NHP4fs42CC-xpZO1ryN-JK-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Wed, 23 Nov 2011 23:26:08 -0600
Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> We are waiting a dochelp response from ms. In addition more data on the
> perf penalty of cutting  the wsize in half would help. In any case thecmore
> serious problem is ignoring the write error not the wsize default

We know there'll be a perf penalty, and I've done some rough numbers
that show about a 30% decrease in some tests. The question is -- is it
a good idea to default to mount options that give better performance
at the expense of interoperability? My vote is no -- the defaults
should be as safe as possible, but we should allow people to set the
wsize higher if they choose. That's what the proposed patch does.

Also, most applications do not ignore write() errors, but a lot of
applications ignore errors on close(). Even the ones that do check for
errors on close() can't usually do much about it other than to log
the error or crash. It's therefore advantageous to avoid that situation
entirely if we can.

The dochelp response won't mean much, IMO. We know there are servers
with this limitation in the field, but they work with Windows. The
casual user will see that Windows works against those servers and Linux
corrupts data, and will conclude that Linux blows.

-- 
Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

  parent reply	other threads:[~2011-11-24 12:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-09 18:37 [PATCH] cifs: lower default wsize when unix extensions are not used Jeff Layton
     [not found] ` <1320863843-29406-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-11-09 18:41   ` Jeff Layton
     [not found]     ` <20111109134140.2105ed9e-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2011-11-09 20:55       ` Steve French
     [not found]         ` <CAH2r5mtmboSEMHbj6ixh6UGSgiTFz1Mn=ZU6fkQaCSu7n6h=EQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-11-09 21:04           ` Jeff Layton
     [not found]             ` <20111109160408.44947815-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2011-11-09 21:14               ` Steve French
     [not found]                 ` <CAH2r5mtGbo4uHzp9KE_Jo3x=hkBewDM8+nvqoVqkyuG4TeRXhQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-11-09 21:34                   ` Jeff Layton
     [not found]                     ` <CAH2r5mupsXVYYkkqdC9fQ=EHfeD6ZeCzV7ggYc0wX_0NR4mhmw@mail.gmail.com>
     [not found]                       ` <CAH2r5mupsXVYYkkqdC9fQ=EHfeD6ZeCzV7ggYc0wX_0NR4mhmw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-11-09 21:41                         ` Jeff Layton
2011-11-23 18:34               ` Björn JACKE
     [not found]                 ` <E1RTHe2-004p4M-7T-dqLtpHMqGvUyWpdLl23E4A@public.gmane.org>
2011-11-23 20:04                   ` Jeff Layton
     [not found]                     ` <CAH2r5muKFRup1BwPqGuiy=+kh-NHP4fs42CC-xpZO1ryN-JK-Q@mail.gmail.com>
     [not found]                       ` <CAH2r5muKFRup1BwPqGuiy=+kh-NHP4fs42CC-xpZO1ryN-JK-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-11-24 12:20                         ` Jeff Layton [this message]
     [not found]                           ` <20111124072036.0fa2ad0d-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2011-11-25  2:30                             ` Steve French
2011-11-09 19:06   ` Pavel Shilovsky
2011-11-09 23:10   ` Shirish Pargaonkar
     [not found]     ` <CADT32eLBeJoeiJUHM5OvK=7vGG1Z5X2NUVh6Hnkfp89u1yySww-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-11-09 23:57       ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111124072036.0fa2ad0d@corrin.poochiereds.net \
    --to=jlayton-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=bj-3ekOc4rQMZmzQB+pC5nmwQ@public.gmane.org \
    --cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=phireph0x-/E1597aS9LQAvxtiuMwx3w@public.gmane.org \
    --cc=piastry-7qunaywFIewox3rIn2DAYQ@public.gmane.org \
    --cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.