From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Weiner Subject: Re: [patch 5/8] mm: memcg: remove unneeded checks from newpage_charge() Date: Thu, 24 Nov 2011 12:58:16 +0100 Message-ID: <20111124115816.GA1225@cmpxchg.org> References: <1322062951-1756-1-git-send-email-hannes@cmpxchg.org> <1322062951-1756-6-git-send-email-hannes@cmpxchg.org> <20111124090443.d3f720c5.kamezawa.hiroyu@jp.fujitsu.com> <20111124090409.GC6843@cmpxchg.org> <20111124103049.GG26036@tiehlicka.suse.cz> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20111124103049.GG26036-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michal Hocko Cc: KAMEZAWA Hiroyuki , Andrew Morton , Balbir Singh , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Thu, Nov 24, 2011 at 11:30:49AM +0100, Michal Hocko wrote: > On Thu 24-11-11 10:04:09, Johannes Weiner wrote: > > From: Johannes Weiner > > Subject: mm: memcg: remove unneeded checks from newpage_charge() fix > > > > Document page state assumptions and catch if they are violated in > > newpage_charge(). > > > > Signed-off-by: Johannes Weiner > > I assume you are going to fold it into the previous one. > Acked-by: Michal Hocko Thanks. I'm under the assumption that incremental patches are better for Andrew, but I forgot why. But yes, this should be folded before going upstream. -- To unsubscribe from this list: send the line "unsubscribe cgroups" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta7.messagelabs.com (mail6.bemta7.messagelabs.com [216.82.255.55]) by kanga.kvack.org (Postfix) with ESMTP id 466886B0096 for ; Thu, 24 Nov 2011 06:58:35 -0500 (EST) Date: Thu, 24 Nov 2011 12:58:16 +0100 From: Johannes Weiner Subject: Re: [patch 5/8] mm: memcg: remove unneeded checks from newpage_charge() Message-ID: <20111124115816.GA1225@cmpxchg.org> References: <1322062951-1756-1-git-send-email-hannes@cmpxchg.org> <1322062951-1756-6-git-send-email-hannes@cmpxchg.org> <20111124090443.d3f720c5.kamezawa.hiroyu@jp.fujitsu.com> <20111124090409.GC6843@cmpxchg.org> <20111124103049.GG26036@tiehlicka.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111124103049.GG26036@tiehlicka.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: KAMEZAWA Hiroyuki , Andrew Morton , Balbir Singh , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Thu, Nov 24, 2011 at 11:30:49AM +0100, Michal Hocko wrote: > On Thu 24-11-11 10:04:09, Johannes Weiner wrote: > > From: Johannes Weiner > > Subject: mm: memcg: remove unneeded checks from newpage_charge() fix > > > > Document page state assumptions and catch if they are violated in > > newpage_charge(). > > > > Signed-off-by: Johannes Weiner > > I assume you are going to fold it into the previous one. > Acked-by: Michal Hocko Thanks. I'm under the assumption that incremental patches are better for Andrew, but I forgot why. But yes, this should be folded before going upstream. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753248Ab1KXL6d (ORCPT ); Thu, 24 Nov 2011 06:58:33 -0500 Received: from zene.cmpxchg.org ([85.214.230.12]:42261 "EHLO zene.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750757Ab1KXL6b (ORCPT ); Thu, 24 Nov 2011 06:58:31 -0500 Date: Thu, 24 Nov 2011 12:58:16 +0100 From: Johannes Weiner To: Michal Hocko Cc: KAMEZAWA Hiroyuki , Andrew Morton , Balbir Singh , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [patch 5/8] mm: memcg: remove unneeded checks from newpage_charge() Message-ID: <20111124115816.GA1225@cmpxchg.org> References: <1322062951-1756-1-git-send-email-hannes@cmpxchg.org> <1322062951-1756-6-git-send-email-hannes@cmpxchg.org> <20111124090443.d3f720c5.kamezawa.hiroyu@jp.fujitsu.com> <20111124090409.GC6843@cmpxchg.org> <20111124103049.GG26036@tiehlicka.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111124103049.GG26036@tiehlicka.suse.cz> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 24, 2011 at 11:30:49AM +0100, Michal Hocko wrote: > On Thu 24-11-11 10:04:09, Johannes Weiner wrote: > > From: Johannes Weiner > > Subject: mm: memcg: remove unneeded checks from newpage_charge() fix > > > > Document page state assumptions and catch if they are violated in > > newpage_charge(). > > > > Signed-off-by: Johannes Weiner > > I assume you are going to fold it into the previous one. > Acked-by: Michal Hocko Thanks. I'm under the assumption that incremental patches are better for Andrew, but I forgot why. But yes, this should be folded before going upstream.