From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH 1.0] virtio: add and use virtio_set_features
Date: Thu, 24 Nov 2011 19:55:57 +0200 [thread overview]
Message-ID: <20111124175436.GA29199@redhat.com> (raw)
In-Reply-To: <4ECE7593.5090902@redhat.com>
On Thu, Nov 24, 2011 at 05:49:23PM +0100, Paolo Bonzini wrote:
> On 11/24/2011 05:42 PM, Michael S. Tsirkin wrote:
> >Most users ignore the return value anyway,
> >and virtio_load needs to look at supported features
> >mask for the diagnostic anyway. So let's use virtio_set_features
> >void.
>
> Could some backend make it a hard failure?
I don't see how, there's no way to report a failure from
an io port write.
> If I understand
> correctly, this would have prevented the BAD_FEATURE bug too.
>
> Paolo
Which bug? what would have prevented it.
next prev parent reply other threads:[~2011-11-24 17:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 12:28 [Qemu-devel] [PATCH 1.0] virtio: add and use virtio_set_features Paolo Bonzini
2011-11-24 16:42 ` Michael S. Tsirkin
2011-11-24 16:49 ` Paolo Bonzini
2011-11-24 17:55 ` Michael S. Tsirkin [this message]
2011-11-25 8:23 ` Paolo Bonzini
2011-11-26 20:45 ` Michael S. Tsirkin
2011-11-28 22:38 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111124175436.GA29199@redhat.com \
--to=mst@redhat.com \
--cc=agraf@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.