From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH] use ncurses-config to find all curses related libs Date: Thu, 24 Nov 2011 20:15:02 +0100 Message-ID: <20111124191502.GA25881@aepfle.de> References: <20111122113507.GA28412@aepfle.de> <20174.36661.814563.526570@mariner.uk.xensource.com> <20111124184917.GA25646@aepfle.de> <20174.37522.349763.828592@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20174.37522.349763.828592@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On Thu, Nov 24, Ian Jackson wrote: > Olaf Hering writes ("Re: [Xen-devel] [PATCH] use ncurses-config to find all curses related libs"): > > On Thu, Nov 24, Ian Jackson wrote: > > > Olaf Hering writes ("[Xen-devel] [PATCH] use ncurses-config to find all curses related libs"): > > > > -CURSES_LIBS = -lncurses > > > > +CURSES_LIBS = $(shell if ! ncurses5-config --libs 2>/dev/null ; then ncurses-config --libs ; fi) > > > > > > In the case where ncurses5-config is not provided, this will fail. > > Sorry, I wasn't sufficiently clear. The case that fails is if neither > ncurses5-config nor ncurses-config is provided. The default should be > to use -lncurses as before. I see. Another if construct, or a check_ncurses script which looks for ncurses5-config or ncurses-config. After some digging in old SuSE releases, ncurses5-config appeared in 11.0 (2008), SLES10 does not have it yes . So blindly relying on -config scripts will likely break building on old distributions. This should work: if ! ncurses5-config --libs 2>/dev/null;then if ! ncurses-config --libs ; then echo '-lncurses' ; fi ; fi Olaf