From: Hagen Paul Pfeifer <hagen@jauu.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Stephen Hemminger <shemminger@vyatta.com>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] netem: rate-latency extension
Date: Fri, 25 Nov 2011 13:02:18 +0100 [thread overview]
Message-ID: <20111125120218.GB2810@hell> (raw)
In-Reply-To: <1322201600.2872.15.camel@edumazet-laptop>
* Eric Dumazet | 2011-11-25 07:13:20 [+0100]:
>Yes, but Hagen change adds a few lines to netem, and netem already
>handles throttling. This is why I believe its a nice enhancement.
We first modified TBF, but TBF address a slightly different task. So the patch
was a little bit awkward and complex (more awkward then the two additional
netem enqueue() lines). So in the end: yes, netem is the right place for this:
only a few lines in netem are required. Additionally: setup a qdisc chain with
TBF, netem, ... is also error prone. Students of mine repeatedly make mistakes
here. This change make a complete emulation setup even more easy. But this is
only a side note.
Hagen
next prev parent reply other threads:[~2011-11-25 12:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 17:39 [PATCH net-next 1/2] netem: rate-latency extension Hagen Paul Pfeifer
2011-11-24 17:39 ` [PATCH net-next 2/2] netem: add cell concept to simulate special MAC behavior Hagen Paul Pfeifer
2011-11-24 22:14 ` [PATCH net-next 1/2] netem: rate-latency extension Eric Dumazet
2011-11-24 22:31 ` Hagen Paul Pfeifer
2011-11-25 1:06 ` Bill Fink
2011-11-25 1:23 ` Hagen Paul Pfeifer
2011-11-25 5:09 ` Stephen Hemminger
2011-11-25 6:13 ` Eric Dumazet
2011-11-25 12:02 ` Hagen Paul Pfeifer [this message]
2011-11-25 2:22 ` [PATCH v2 net-next 1/2] netem: rate extension Hagen Paul Pfeifer
2011-11-25 2:22 ` [PATCH v2 net-next 2/2] netem: add cell concept to simulate special MAC behavior Hagen Paul Pfeifer
2011-11-28 23:01 ` Eric Dumazet
2011-11-28 23:30 ` Hagen Paul Pfeifer
2011-11-28 23:48 ` Eric Dumazet
2011-11-29 0:07 ` Hagen Paul Pfeifer
2011-11-26 11:00 ` [PATCH v2 net-next 1/2] netem: rate extension Eric Dumazet
2011-11-25 2:23 ` [PATCH v2 iproute2 1/2] utils: add s32 parser Hagen Paul Pfeifer
2011-11-25 2:23 ` [PATCH v2 iproute2 2/2] tc: netem rate shaping and cell extension Hagen Paul Pfeifer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111125120218.GB2810@hell \
--to=hagen@jauu.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.