diff for duplicates of <201111251426.26469.thomas@osterried.de> diff --git a/a/1.txt b/N1/1.txt index 1e44aea..4fb50c5 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -16,7 +16,7 @@ static ax25_digi *nr_call_to_digi(ax25_digi *digi, int ndigis, { int i; - if (ndigis = 0) + if (ndigis == 0) return NULL; ################ here we leave @@ -35,7 +35,7 @@ static ax25_digi *nr_call_to_digi(ax25_digi *digi, int ndigis, Image ndigi is 8 (AX25_MAX_DIGIS), as large as nr_route.digipeaters (because it's digipeaters[AX25_MAX_DIGIS]). -we fill the array from i = 0 to i < ndigis (=7) -> 8 times = sizeof(digipeaters) +we fill the array from i = 0 to i < ndigis (=7) -> 8 times == sizeof(digipeaters) -> everything is fine with that. @@ -69,17 +69,17 @@ vy 73, > >> case SIOCADDRT: > >> if (copy_from_user(&nr_route, arg, sizeof(struct nr_route_struct))) > >> return -EFAULT; -> >> - if ((dev = nr_ax25_dev_get(nr_route.device)) = NULL) +> >> - if ((dev = nr_ax25_dev_get(nr_route.device)) == NULL) > >> + if (nr_route.ndigis > AX25_MAX_DIGIS) > >> return -EINVAL; > >> - if (nr_route.ndigis < 0 || nr_route.ndigis > AX25_MAX_DIGIS) { > >> - dev_put(dev); -> >> + if ((dev = nr_ax25_dev_get(nr_route.device)) = NULL) +> >> + if ((dev = nr_ax25_dev_get(nr_route.device)) == NULL) > >> return -EINVAL; > >> - } > >> switch (nr_route.type) { > >> case NETROM_NODE: -> >> if (strnlen(nr_route.mnemonic, 7) = 7) { +> >> if (strnlen(nr_route.mnemonic, 7) == 7) { > > > > I realy do not know if that matters but some use AX25_MAX_DIGIS as array > > and therefore it should be >=AX25_MAX_DIGIS. diff --git a/a/content_digest b/N1/content_digest index 3dcec02..ec84d86 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\04ECF8629.7000301@bfs.de\0" "From\0Thomas Osterried <thomas@osterried.de>\0" "Subject\0Re: [PATCH 3/4] NET: NETROM: Cleanup argument SIOCADDRT ioctl argument checking.\0" - "Date\0Fri, 25 Nov 2011 13:26:25 +0000\0" + "Date\0Fri, 25 Nov 2011 14:26:25 +0100\0" "To\0wharms@bfs.de\0" "Cc\0Ralf Baechle <ralf@linux-mips.org>" David S. Miller <davem@davemloft.net> @@ -30,7 +30,7 @@ "{\n" " int i;\n" "\n" - " if (ndigis = 0)\n" + " if (ndigis == 0)\n" " return NULL;\n" "\n" " ################ here we leave\n" @@ -49,7 +49,7 @@ "\n" "Image ndigi is 8 (AX25_MAX_DIGIS), as large as nr_route.digipeaters (because it's digipeaters[AX25_MAX_DIGIS]).\n" "\n" - "we fill the array from i = 0 to i < ndigis (=7) -> 8 times = sizeof(digipeaters)\n" + "we fill the array from i = 0 to i < ndigis (=7) -> 8 times == sizeof(digipeaters)\n" "\n" "-> everything is fine with that.\n" "\n" @@ -83,17 +83,17 @@ "> >> \tcase SIOCADDRT:\n" "> >> \t\tif (copy_from_user(&nr_route, arg, sizeof(struct nr_route_struct)))\n" "> >> \t\t\treturn -EFAULT;\n" - "> >> -\t\tif ((dev = nr_ax25_dev_get(nr_route.device)) = NULL)\n" + "> >> -\t\tif ((dev = nr_ax25_dev_get(nr_route.device)) == NULL)\n" "> >> +\t\tif (nr_route.ndigis > AX25_MAX_DIGIS)\n" "> >> \t\t\treturn -EINVAL;\n" "> >> -\t\tif (nr_route.ndigis < 0 || nr_route.ndigis > AX25_MAX_DIGIS) {\n" "> >> -\t\t\tdev_put(dev);\n" - "> >> +\t\tif ((dev = nr_ax25_dev_get(nr_route.device)) = NULL)\n" + "> >> +\t\tif ((dev = nr_ax25_dev_get(nr_route.device)) == NULL)\n" "> >> \t\t\treturn -EINVAL;\n" "> >> -\t\t}\n" "> >> \t\tswitch (nr_route.type) {\n" "> >> \t\tcase NETROM_NODE:\n" - "> >> \t\t\tif (strnlen(nr_route.mnemonic, 7) = 7) {\n" + "> >> \t\t\tif (strnlen(nr_route.mnemonic, 7) == 7) {\n" "> > \n" "> > I realy do not know if that matters but some use AX25_MAX_DIGIS as array\n" "> > and therefore it should be >=AX25_MAX_DIGIS.\n" @@ -113,4 +113,4 @@ "> > \n" > -6deb6d012767a123936d0f82687ab7aebecb7d38a39a9d0fcbce12ce7d5e48f4 +7c6639380ca7bdc472728fff82d2b5bb26532c6532de543bb1460ce07764f066
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.