From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Tero Kristo <t-kristo@ti.com>
Cc: linux-omap@vger.kernel.org, khilman@ti.com, lrg@ti.com,
gg@slimlogic.co.uk, rnayak@ti.com, b-cousson@ti.com
Subject: Re: [PATCHv6 1/6] regulator: core: add support for external get/set_voltage
Date: Fri, 25 Nov 2011 17:29:45 +0000 [thread overview]
Message-ID: <20111125172945.GJ5315@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1322241632.13828.10.camel@sokoban>
On Fri, Nov 25, 2011 at 07:20:32PM +0200, Tero Kristo wrote:
> On Fri, 2011-11-25 at 16:52 +0000, Mark Brown wrote:
> > My basic reaction to this is "eew, ick". Doing this with a runtime call
> > just feels badly joined up, and there's nothing here which hands off the
> > configuration between the various drivers involved in the transitions.
> > We need to make sure that the voltage doesn't suddenly lurch around when
> > doing transitions.
> Would you feel better if we just hacked around with the twl-regulator
> driver and added a compile time switch for the voltage get/set for smps
> regulators?
No, that's clearly going to break multi-board kernel images. If this
is something board specific platform/device tree data sounds like the
way forwards.
next prev parent reply other threads:[~2011-11-25 17:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-25 16:29 [PATCHv6 0/6] OMAP: SMPS support for TWL regulators Tero Kristo
2011-11-25 16:29 ` [PATCHv6 1/6] regulator: core: add support for external get/set_voltage Tero Kristo
2011-11-25 16:52 ` Mark Brown
2011-11-25 17:20 ` Tero Kristo
2011-11-25 17:29 ` Mark Brown [this message]
2011-11-25 17:59 ` Tero Kristo
2011-11-25 18:48 ` Mark Brown
2011-11-28 8:15 ` Tero Kristo
2011-11-25 16:29 ` [PATCHv6 2/6] omap3: add common twl configurations for vdd1 and vdd2 Tero Kristo
2011-11-25 16:29 ` [PATCHv6 3/6] TEMP: OMAP3: beagle rev-c4: enable OPP6 Tero Kristo
2011-11-25 16:29 ` [PATCHv6 4/6] regulator: twl: fix twl4030 support for smps regulators Tero Kristo
2011-11-25 16:55 ` Mark Brown
2011-11-25 17:08 ` Tero Kristo
2011-11-25 16:29 ` [PATCHv6 5/6] omap3: voltage: fix channel configuration Tero Kristo
2011-11-25 16:29 ` [PATCHv6 6/6] omap3: voltage: add external controller for VDD1 and VDD2 Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111125172945.GJ5315@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=b-cousson@ti.com \
--cc=gg@slimlogic.co.uk \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=rnayak@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.