Re: [PATCH 1/2] drivers/staging/vt6656/iwctl.c: Change PRINT_K and

[Greg KH <greg@kroah.com>]

On Wed, Nov 09, 2011 at 06:37:13PM -0200, Marcos Paulo de Souza wrote:
> As asked in the TODO file of this driver, the PRINTK and DBG_PRT macros
> must be removed. The debug messages was improved too.
> 
> Signed-off-by: Marcos Paulo de Souza <marcos.mage@gmail.com>
> ---
>  drivers/staging/vt6656/iwctl.c |  135 ++++++++++++++++++++--------------------
>  1 files changed, 67 insertions(+), 68 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/iwctl.c b/drivers/staging/vt6656/iwctl.c
> index 2121205..8c1ca49 100644
> --- a/drivers/staging/vt6656/iwctl.c
> +++ b/drivers/staging/vt6656/iwctl.c
> @@ -68,7 +68,6 @@ static const long frequency_list[] = {
>  
>  
>  //static int          msglevel                =MSG_LEVEL_DEBUG;
> -static int          msglevel                =MSG_LEVEL_INFO;
>  
>  
>  /*---------------------  Static Variables  --------------------------*/
> @@ -110,7 +109,7 @@ static int iwctl_commit(struct net_device *dev,
>  			      void *wrq,
>  			      char *extra)
>  {
> -    DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO " SIOCSIWCOMMIT\n");
> +	pr_debug(" SIOCSIWCOMMIT\n");

Stuff like this isn't even needed anymore.

And again, please use dev_dbg(), not pr_debug().

thanks,

greg k-h