From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753256Ab1K0KL4 (ORCPT ); Sun, 27 Nov 2011 05:11:56 -0500 Received: from out2.smtp.messagingengine.com ([66.111.4.26]:58105 "EHLO out2.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753134Ab1K0KLy (ORCPT ); Sun, 27 Nov 2011 05:11:54 -0500 X-Sasl-enc: 4b3Bavb1lW3wwvppQm4qCNtEx8Pv//HRQCXvbM50EX3g 1322388712 Date: Sat, 26 Nov 2011 19:49:19 -0800 From: Greg KH To: Sarah Sharp Cc: Aman Deep , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] xHCI: Adding #define values used for hub descriptor Message-ID: <20111127034919.GA30452@kroah.com> References: <1321970616-1298-1-git-send-email-amandeep3986@gmail.com> <20111122195714.GA2815@xanatos> <20111123170006.GB5792@xanatos> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20111123170006.GB5792@xanatos> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 23, 2011 at 09:00:06AM -0800, Sarah Sharp wrote: > On Wed, Nov 23, 2011 at 10:20:10AM +0530, Aman Deep wrote: > > Hi Sarah, > > > > > > > > > > > > Also use some #defines in places where magic numbers are being used. > > > > > > Looks fine to me for the xHCI changes.  I copied most of the hub > > > descriptor code from EHCI, so it will need the same treatment. > > > > Okay, thanks. I will try to make some of these changes into other host > > controller drivers also as > > soon as I can. > > > > > > > > Acked-by: Sarah Sharp > > > > Thanks for the ACK, Sarah. > > > > > > > > The #defines look a bit odd to me, like you're using spaces instead of > > > tabs to separate the name and value, or your mail program is converting > > > tabs to spaces.  Do the numbers line up for you? > > > > Actually, both the HUB_CHAR_TTTT and HUB_CHAR_PORTIND were already using > > spaces instead of tabs. I just copied them to the lines below, thats > > why they still have > > spaces between define and value. > > > > But thanks for info. I will take more care about this in future. > > > > Do you want me to make any changes in this patch ? > > Fixing them up to have tabs instead of spaces would be nice, but is not > required. :) I fixed them up by hand, so don't worry about it. greg k-h