From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Rajendra Nayak <rnayak@ti.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] regulator: Avoid potential NULL dereference in reg_fixed_voltage_probe()
Date: Sun, 27 Nov 2011 11:35:29 +0000 [thread overview]
Message-ID: <20111127113529.GG2896@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1322360030.6779.1.camel@phoenix>
On Sun, Nov 27, 2011 at 10:13:50AM +0800, Axel Lin wrote:
> - if (pdev->dev.of_node)
> + if (pdev->dev.of_node) {
> config = of_get_fixed_voltage_config(&pdev->dev);
> + if (!config)
> + return -ENOMEM;
> + }
Looking at this I'm thinking it's better to just drop the check for
of_node entirely and just let of_get_fixed_voltage_config() fail to find
what it needs.
next prev parent reply other threads:[~2011-11-27 11:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-27 2:13 [PATCH] regulator: Avoid potential NULL dereference in reg_fixed_voltage_probe() Axel Lin
2011-11-27 11:35 ` Mark Brown [this message]
2011-11-27 11:56 ` Axel Lin
2011-11-27 12:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111127113529.GG2896@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.