From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Greg KH <gregkh@suse.de>
Cc: Linux PM list <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] PM / Sleep: Drop pm_op() and pm_noirq_op()
Date: Mon, 28 Nov 2011 12:58:12 +0100 [thread overview]
Message-ID: <201111281258.12389.rjw@sisk.pl> (raw)
In-Reply-To: <20111127233029.GB30818@suse.de>
On Monday, November 28, 2011, Greg KH wrote:
> On Sun, Nov 27, 2011 at 11:59:36PM +0100, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> >
> > The helper functions pm_op() and pm_noirq_op() are not really
> > necessary and they don't do anything useful, so drop them.
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
>
> Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Unfortunately, this one isn't correct, because it would make the PM core
silently ignore the freeze/thaw and poweroff/restore callbacks, so I'm
withdrawing it.
Patch [1/2] is still OK, though.
Thanks,
Rafael
prev parent reply other threads:[~2011-11-28 11:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-27 22:57 [PATCH 0/2] PM / Sleep: Simplyfy device suspend/resume code paths Rafael J. Wysocki
2011-11-27 22:59 ` [PATCH 1/2] PM / Sleep: Unify diagnostic messages from device suspend/resume Rafael J. Wysocki
2011-11-27 23:30 ` Greg KH
2011-11-27 23:47 ` Rafael J. Wysocki
2011-11-27 22:59 ` [PATCH 2/2] PM / Sleep: Drop pm_op() and pm_noirq_op() Rafael J. Wysocki
2011-11-27 23:30 ` Greg KH
2011-11-28 11:58 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111281258.12389.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.