All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Milan Broz <mbroz@redhat.com>
Cc: lczerner@redhat.com, dm-devel@redhat.com
Subject: Re: dm: fix discard support in dm_io
Date: Mon, 28 Nov 2011 08:59:58 -0500	[thread overview]
Message-ID: <20111128135958.GA24022@redhat.com> (raw)
In-Reply-To: <1322249289-1263-1-git-send-email-mbroz@redhat.com>

On Fri, Nov 25 2011 at  2:28pm -0500,
Milan Broz <mbroz@redhat.com> wrote:

> This patch adds support for discard request to dm_io interface.
> 
> Currently dm_mirror can send REQ_DISCARD bios if running over
> discard enabled device and without support in dm_io the system
> crashes badly.
> 
> BUG: unable to handle kernel paging request at 00800000
> IP:  __bio_add_page.part.17+0xf5/0x1e0
> ...
>  bio_add_page+0x56/0x70
>  dispatch_io+0x1cf/0x240 [dm_mod]
>  ? km_get_page+0x50/0x50 [dm_mod]
>  ? vm_next_page+0x20/0x20 [dm_mod]
>  ? mirror_flush+0x130/0x130 [dm_mirror]
>  dm_io+0xdc/0x2b0 [dm_mod]
> ...
> 
> Signed-off-by: Milan Broz <mbroz@redhat.com>

Acked-by: Mike Snitzer <snitzer@redhat.com>

  reply	other threads:[~2011-11-28 13:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-25 19:28 [PATCH] dm: fix discard support in dm_io Milan Broz
2011-11-28 13:59 ` Mike Snitzer [this message]
2011-12-05 20:00 ` [PATCH v2] " Milan Broz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111128135958.GA24022@redhat.com \
    --to=snitzer@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=lczerner@redhat.com \
    --cc=mbroz@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.