From: Ted Ts'o <tytso@mit.edu>
To: Robin Dong <hao.bigrat@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2fsck: fix "can't find dup_blk" error
Date: Mon, 28 Nov 2011 12:02:25 -0500 [thread overview]
Message-ID: <20111128170225.GA4348@thunk.org> (raw)
In-Reply-To: <CAFZ0FUUQ9LA67DS2tJLd1KoQpKT-YCd4A=GCiAui2Xju4tFQXw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 719 bytes --]
Ok, I was able to replicate it, and created a small test case (see
attached), but it turns out your patch wasn't sufficient. It didn't
actually fix the problem correctly, and left the file system in a
corrupted state, which was seen when we ran e2fsck a second time and
the i_blocks field was not correctly.
Your patch also resulted in blocks within a logical cluster
incorrectly assigned to two physical clusters. (I still need to add
some code in e2fsck to notice this particular corruption, but it's
highly unlikely for this to happen due to hardware errors --- just
kernel/e2fsck bugs.)
I'll attach to this mail thread the patches I used to fix this, plus
the test case.
- Ted
[-- Attachment #2: image.gz --]
[-- Type: application/octet-stream, Size: 4668 bytes --]
next prev parent reply other threads:[~2011-11-28 17:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 2:52 [PATCH] e2fsck: fix "can't find dup_blk" error Robin Dong
2011-11-19 4:02 ` Ted Ts'o
2011-11-19 8:32 ` Robin Dong
2011-11-28 17:02 ` Ted Ts'o [this message]
2011-11-28 17:15 ` [PATCH 1/2] e2fsck: fix handling of duplicate blocks with bigalloc file systems Theodore Ts'o
2011-11-28 17:15 ` [PATCH 2/2] tests: add test case for multiply claimed blocks with bigalloc Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111128170225.GA4348@thunk.org \
--to=tytso@mit.edu \
--cc=hao.bigrat@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.