From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastian Blank Subject: Re: [PATCH 1/5] xen/sys/hypervisor: Export guest_properties/is_initial_domain Date: Mon, 28 Nov 2011 19:38:30 +0100 Message-ID: <20111128183830.GC6828@wavehammer.waldi.eu.org> References: <1322431628-21760-1-git-send-email-waldi@debian.org> <1322431628-21760-2-git-send-email-waldi@debian.org> <20111128181439.GB21369@andromeda.dapyr.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20111128181439.GB21369@andromeda.dapyr.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Mon, Nov 28, 2011 at 02:14:39PM -0400, Konrad Rzeszutek Wilk wrote: > On Sun, Nov 27, 2011 at 11:07:04PM +0100, Bastian Blank wrote: > > diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c > > index 1e0fe01..d0916e8 100644 > > --- a/drivers/xen/sys-hypervisor.c > > +++ b/drivers/xen/sys-hypervisor.c > > @@ -355,6 +355,35 @@ static void xen_properties_destroy(void) > > sysfs_remove_group(hypervisor_kobj, &xen_properties_group); > > } > > > > +/* xen guest properties info */ > > Properties is plural, but this is a single attribute. Just like the old /proc/xen/capabilites, it only supported one attribute ever. However it could export a flag for hvm domain. > Perhaps the name 'is_initial_domain' would be a > better name? It is already called this was. > What is the purpose of this attribute? Replace /proc/xen/capabilities. See <20100605162947.GA31336@wavehammer.waldi.eu.org> > Who/what tools > benefit from this? The init scripts are the only users. Bastian -- Deflector shields just came on, Captain.