All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: rjw@sisk.pl, linux-kernel@vger.kernel.org,
	linux-nfs@vger.kernel.org, linux-pm@vger.kernel.org,
	john@calva.com, trond.myklebust@netapp.com,
	marek.belisko@gmail.com, awilliam@redhat.com
Subject: Re: [PATCH v3 1/2] sunrpc: make rpc_wait_bit_killable handle freeze events
Date: Mon, 28 Nov 2011 12:39:01 -0800	[thread overview]
Message-ID: <20111128203901.GG18864@google.com> (raw)
In-Reply-To: <1322510488-21189-2-git-send-email-jlayton@redhat.com>

Hello,

On Mon, Nov 28, 2011 at 03:01:27PM -0500, Jeff Layton wrote:
> +#define freezable_schedule()						\
> +({									\
> +	freezer_do_not_count();						\
> +	if (!try_to_freeze())						\
> +		schedule();						\
> +	freezer_count();						\
> +})

I don't think you need try_to_freeze() there when you apply this on
top of pm-freezer branch.  Per-task freezing flag is gone and freezing
condition is completely transient from the POV of each task and the
freezer also doesn't care at all whether a task enters freezer or
becomes unfreezable.

Thanks.

-- 
tejun

  reply	other threads:[~2011-11-28 20:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-28 20:01 [PATCH v3 0/2] nfs/sunrpc: allow freezing of tasks with NFS calls in flight Jeff Layton
2011-11-28 20:01 ` [PATCH v3 1/2] sunrpc: make rpc_wait_bit_killable handle freeze events Jeff Layton
2011-11-28 20:39   ` Tejun Heo [this message]
2011-11-28 20:01 ` [PATCH v3 2/2] nfs: make TASK_KILLABLE sleeps attempt to freeze Jeff Layton
2011-11-28 20:22 ` [PATCH v3 0/2] nfs/sunrpc: allow freezing of tasks with NFS calls in flight Rafael J. Wysocki
2011-11-28 20:40   ` Tejun Heo
2011-11-28 21:07     ` Rafael J. Wysocki
2011-11-28 21:09       ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111128203901.GG18864@google.com \
    --to=tj@kernel.org \
    --cc=awilliam@redhat.com \
    --cc=jlayton@redhat.com \
    --cc=john@calva.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=marek.belisko@gmail.com \
    --cc=rjw@sisk.pl \
    --cc=trond.myklebust@netapp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.