From: s.hauer@pengutronix.de (s.hauer at pengutronix.de)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] USB: ehci-mxc: get rid of the uses of cpu_is_mx()
Date: Tue, 29 Nov 2011 09:21:39 +0100 [thread overview]
Message-ID: <20111129082139.GG27267@pengutronix.de> (raw)
In-Reply-To: <35AB98346D25394A9354ED89C4D76587226AE3@039-SN1MPN1-002.039d.mgd.msft.net>
On Tue, Nov 29, 2011 at 08:02:53AM +0000, Chen Peter-B29397 wrote:
> >
> > In the driver you would then do a clk_get() for those three clocks
> > independent of the platform.
> >
> The reason why I add this patch is not for clk things, it is for:
> 1. Coming device driver
> 2. Handle things difference between SoC's. not only clk, others
> like low power, wakeup, hsic, or other will comes in future.
The ehci is a standardized core. Please be *very* careful with what you
add to this driver. As said in my other mail, the real differences are
in the phys and the phy handling code should not be in the ehci-mxc
driver at all.
Rather than adding random phy code to the driver you should write phy
drivers. If you still think that there is code missing in this driver
please explain further.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2011-11-29 8:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 7:09 [PATCH] USB: ehci-mxc: get rid of the uses of cpu_is_mx() Peter Chen
2011-11-29 7:42 ` Lothar Waßmann
2011-11-29 8:02 ` Chen Peter-B29397
2011-11-29 8:12 ` Uwe Kleine-König
2011-11-29 8:21 ` s.hauer at pengutronix.de [this message]
2011-11-29 10:57 ` Chen Peter-B29397
2011-11-29 19:21 ` s.hauer at pengutronix.de
2011-11-30 3:24 ` Chen Peter-B29397
2011-11-29 7:52 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111129082139.GG27267@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.