From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Mike Galbraith <efault@gmx.de>, Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 12/25] perf symbols: Add nr_events to symbol_conf
Date: Tue, 29 Nov 2011 09:52:05 -0200 [thread overview]
Message-ID: <20111129115205.GA2244@infradead.org> (raw)
In-Reply-To: <4ED46336.1000207@gmail.com>
Em Mon, Nov 28, 2011 at 09:44:38PM -0700, David Ahern escreveu:
> On 11/28/2011 04:14 PM, Arnaldo Carvalho de Melo wrote:
> > From: Arnaldo Carvalho de Melo <acme@redhat.com>
> > Since symbol__alloc_hists need it, to avoid passing it around in many
> > functions have it in the symbol_conf struct.
>
> I get why you want to do this, but symbol_conf seems to be an odd
> choice. This is number of events, not how to resolve or display symbols.
Well, its related to something you do per-symbol, namely annotate how
many hits per ip per event it got in its addr range.
I plan at some point look again at the symbol system to check things
like this, the filter, the need to have a map to load things, but for
now I think we can leave it there.
- Arnaldo
next prev parent reply other threads:[~2011-11-29 11:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 23:14 [GIT PULL 00/25] perf/core fixes and improvements Arnaldo Carvalho de Melo
2011-11-28 23:14 ` [PATCH 01/25] perf tools: Eliminate duplicate code and use PATH_MAX consistently Arnaldo Carvalho de Melo
2011-11-28 23:14 ` [PATCH 02/25] perf tools: Simplify debugfs mountpoint handling code Arnaldo Carvalho de Melo
2011-11-28 23:14 ` [PATCH 03/25] perf evlist: Introduce perf_evlist__add_attrs Arnaldo Carvalho de Melo
2011-11-28 23:14 ` [PATCH 04/25] perf evlist: Introduce add_tracepoints method Arnaldo Carvalho de Melo
2011-11-28 23:14 ` [PATCH 05/25] perf evsel: Introduce config attr method Arnaldo Carvalho de Melo
2011-11-28 23:14 ` [PATCH 06/25] perf evlist: Introduce {prepare,start}_workload refactored from 'perf record' Arnaldo Carvalho de Melo
2011-11-28 23:14 ` [PATCH 07/25] perf evlist: Handle default value for 'pages' on mmap method Arnaldo Carvalho de Melo
2011-11-28 23:14 ` [PATCH 08/25] perf record: Move mmap_pages to perf_record_opts Arnaldo Carvalho de Melo
2011-11-28 23:14 ` [PATCH 09/25] perf session: Move threads to struct machine Arnaldo Carvalho de Melo
2011-11-28 23:14 ` [PATCH 10/25] perf record: Move 'group' to perf_event_ops Arnaldo Carvalho de Melo
2011-11-28 23:14 ` [PATCH 11/25] perf ui progress: Fix divide by zero Arnaldo Carvalho de Melo
2011-11-28 23:14 ` [PATCH 12/25] perf symbols: Add nr_events to symbol_conf Arnaldo Carvalho de Melo
2011-11-29 4:44 ` David Ahern
2011-11-29 11:52 ` Arnaldo Carvalho de Melo [this message]
2011-11-28 23:14 ` [PATCH 13/25] perf evlist: Introduce id_hdr_size method out of perf_session Arnaldo Carvalho de Melo
2011-11-28 23:14 ` [PATCH 14/25] perf event: perf_event_ops->attr() manipulates only an evlist Arnaldo Carvalho de Melo
2011-11-28 23:14 ` [PATCH 15/25] perf session: Remove superfluous callchain_cursor member Arnaldo Carvalho de Melo
2011-11-28 23:14 ` [PATCH 16/25] perf tools: Use evsel->attr.sample_type instead of session->sample_type Arnaldo Carvalho de Melo
2011-11-28 23:14 ` [PATCH 17/25] perf report: Group options in a struct Arnaldo Carvalho de Melo
2011-11-28 23:14 ` [PATCH 18/25] perf annotate: " Arnaldo Carvalho de Melo
2011-11-28 23:14 ` [PATCH 19/25] perf tools: Pass tool context in the the perf_event_ops functions Arnaldo Carvalho de Melo
2011-11-28 23:14 ` [PATCH 20/25] perf tools: Resolve machine earlier and pass it to perf_event_ops Arnaldo Carvalho de Melo
2011-11-28 23:14 ` [PATCH 21/25] perf tools: Rename perf_event_ops to perf_tool Arnaldo Carvalho de Melo
2011-11-28 23:14 ` [PATCH 22/25] perf top: Stop using globals for tool state Arnaldo Carvalho de Melo
2011-11-28 23:14 ` [PATCH 23/25] perf tools: make -C consistent across commands (for cpu list arg) Arnaldo Carvalho de Melo
2011-11-28 23:14 ` [PATCH 24/25] perf script: Add comm filtering option Arnaldo Carvalho de Melo
2011-11-28 23:14 ` [PATCH 25/25] perf tools: Save some loops using perf_evlist__id2evsel Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111129115205.GA2244@infradead.org \
--to=acme@infradead.org \
--cc=dsahern@gmail.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.