From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Tom Herbert <therbert@google.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v4 06/10] e1000e: Support for byte queue limits
Date: Tue, 29 Nov 2011 13:01:37 -0800 [thread overview]
Message-ID: <20111129130137.000009ce@unknown> (raw)
In-Reply-To: <alpine.DEB.2.00.1111281819350.24413@pokey.mtv.corp.google.com>
On Mon, 28 Nov 2011 18:33:16 -0800
Tom Herbert <therbert@google.com> wrote:
> Changes to e1000e to use byte queue limits.
First: thanks Tom for looking into e1000e with this work.
> @@ -1096,6 +1097,10 @@ static bool e1000_clean_tx_irq(struct e1000_adapter *adapter)
> if (cleaned) {
> total_tx_packets += buffer_info->segs;
> total_tx_bytes += buffer_info->bytecount;
> + if (buffer_info->skb) {
> + bytes_compl += buffer_info->skb->len;
whats wrong with using total_tx_bytes or buffer_info->bytecount? it
contains the "bytes on the wire" value which will be slightly larger
than skb->len, but avoids warming the skb->len cacheline unnecessarily.
the rest of the patch to e1000e looks okay.
next prev parent reply other threads:[~2011-11-29 21:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 2:33 [PATCH v4 06/10] e1000e: Support for byte queue limits Tom Herbert
2011-11-29 21:01 ` Jesse Brandeburg [this message]
2011-12-01 1:04 ` Tom Herbert
2011-12-01 10:12 ` Eric Dumazet
2011-12-01 16:32 ` Tom Herbert
2011-12-01 16:40 ` Eric Dumazet
2011-12-01 17:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111129130137.000009ce@unknown \
--to=jesse.brandeburg@intel.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.