From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Avoid using mappable space for relocation processing through the CPU Date: Tue, 29 Nov 2011 16:34:41 +0100 Message-ID: <20111129153441.GC5667@phenom.ffwll.local> References: <1322579560-15548-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 2F1319E76C for ; Tue, 29 Nov 2011 07:33:19 -0800 (PST) Received: by eekd1 with SMTP id d1so1352622eek.36 for ; Tue, 29 Nov 2011 07:33:18 -0800 (PST) Content-Disposition: inline In-Reply-To: <1322579560-15548-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Nov 29, 2011 at 03:12:40PM +0000, Chris Wilson wrote: > We try to avoid writing the relocations through the uncached GTT, if the > buffer is currently in the CPU write domain and so will be flushed out to > main memory afterwards anyway. Also on SandyBridge we can safely write > to the pages in cacheable memory, so long as the buffer is LLC mapped. > In either of these caches, we therefore do not need to force the > reallocation of the buffer into the mappable region of the GTT, reducing > the aperture pressure. > > Signed-off-by: Chris Wilson The error_state capture currently relies on us pinning buffers as mappable when they contain relocations (and userspace always submitting a batchbuffers containing relocations). You break that guarantee without fixing up the error capture code. Otherwise I like this. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48