From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 29 Nov 2011 16:06:56 -0800 From: Stephen Hemminger Message-ID: <20111129160656.7a96375e@nehalam.linuxnetplumber.net> In-Reply-To: <20111129.185433.1527626185550800872.davem@davemloft.net> References: <201111251216.37466.vitas@nppfactor.kiev.ua> <20111129.185433.1527626185550800872.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH] bridge: master device stuck in no-carrier state forever when in user-stp mode List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Miller Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org On Tue, 29 Nov 2011 18:54:33 -0500 (EST) David Miller wrote: > From: Vitalii Demianets > Date: Fri, 25 Nov 2011 12:16:37 +0200 > > > When in user-stp mode, bridge master do not follow state of its slaves, so > > after the following sequence of events it can stuck forever in no-carrier > > state: > > 1) turn stp off > > 2) put all slaves down - master device will follow their state and also go in > > no-carrier state > > 3) turn stp on with bridge-stp script returning 0 (go to the user-stp mode) > > Now bridge master won't follow slaves' state and will never reach running > > state. > > > > This patch solves the problem by making user-stp and kernel-stp behavior > > similar regarding master following slaves' states. > > > > Signed-off-by: Vitalii Demianets > > Stephen, please review this patch, thanks. Agree that it is a problem, but want to fix the code up. The logic can be done slightly cleaner. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] bridge: master device stuck in no-carrier state forever when in user-stp mode Date: Tue, 29 Nov 2011 16:06:56 -0800 Message-ID: <20111129160656.7a96375e@nehalam.linuxnetplumber.net> References: <201111251216.37466.vitas@nppfactor.kiev.ua> <20111129.185433.1527626185550800872.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org To: David Miller Return-path: In-Reply-To: <20111129.185433.1527626185550800872.davem@davemloft.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On Tue, 29 Nov 2011 18:54:33 -0500 (EST) David Miller wrote: > From: Vitalii Demianets > Date: Fri, 25 Nov 2011 12:16:37 +0200 > > > When in user-stp mode, bridge master do not follow state of its slaves, so > > after the following sequence of events it can stuck forever in no-carrier > > state: > > 1) turn stp off > > 2) put all slaves down - master device will follow their state and also go in > > no-carrier state > > 3) turn stp on with bridge-stp script returning 0 (go to the user-stp mode) > > Now bridge master won't follow slaves' state and will never reach running > > state. > > > > This patch solves the problem by making user-stp and kernel-stp behavior > > similar regarding master following slaves' states. > > > > Signed-off-by: Vitalii Demianets > > Stephen, please review this patch, thanks. Agree that it is a problem, but want to fix the code up. The logic can be done slightly cleaner.