From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Avoid using mappable space for relocation processing through the CPU Date: Tue, 29 Nov 2011 20:22:13 +0100 Message-ID: <20111129192213.GG11090@phenom.ffwll.local> References: <1322579560-15548-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ey0-f177.google.com (mail-ey0-f177.google.com [209.85.215.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 084B99E754 for ; Tue, 29 Nov 2011 11:20:50 -0800 (PST) Received: by eaac10 with SMTP id c10so4164429eaa.36 for ; Tue, 29 Nov 2011 11:20:50 -0800 (PST) Content-Disposition: inline In-Reply-To: <1322579560-15548-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Nov 29, 2011 at 03:12:40PM +0000, Chris Wilson wrote: > We try to avoid writing the relocations through the uncached GTT, if the > buffer is currently in the CPU write domain and so will be flushed out to > main memory afterwards anyway. Also on SandyBridge we can safely write > to the pages in cacheable memory, so long as the buffer is LLC mapped. > In either of these caches, we therefore do not need to force the > reallocation of the buffer into the mappable region of the GTT, reducing > the aperture pressure. > > Signed-off-by: Chris Wilson With the improved error_state capture code this is Reviewed-by: Daniel Vetter -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48