From: Al Viro <viro@ZenIV.linux.org.uk>
To: Joe Perches <joe@perches.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 16/28] namespace: checkpatch wanking
Date: Wed, 30 Nov 2011 02:22:45 +0000 [thread overview]
Message-ID: <20111130022245.GS2203@ZenIV.linux.org.uk> (raw)
In-Reply-To: <a3527806b3af190204da9de1df1bfe4421ed6101.1322609673.git.joe@perches.com>
On Tue, Nov 29, 2011 at 06:14:14PM -0800, Joe Perches wrote:
> Fix a few style things.
>
> $ ./scripts/checkpatch.pl -f --terse --nosummary fs/namespace.c | \
> cut -f3- -d":" | sort | uniq -c
> 1 ERROR: do not initialise statics to 0 or NULL
> 2 ERROR: do not use assignment in if condition
> 1 ERROR: "foo * bar" should be "foo *bar"
> 1 ERROR: need consistent spacing around '|' (ctx:VxW)
> 1 WARNING: braces {} are not necessary for single statement blocks
> 3 WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> 4 WARNING: line over 80 characters
> 9 WARNING: please, no space before tabs
> 1 WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
> 1 WARNING: Use #include <linux/unistd.h> instead of <asm/unistd.h>
NAK. First of all, wanking it certainly is; moreover, it creates shitloads
of conflicts with patches in vfs.git#vfsmount-guts
next prev parent reply other threads:[~2011-11-30 2:22 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 2:13 [PATCH 00/28] fs: Logging style neatening and checkpatch wanking Joe Perches
2011-11-30 2:13 ` [PATCH 01/28] buffer: Use pr_<level> Joe Perches
2011-11-30 2:14 ` [PATCH 02/28] mbcache: Use current logging styles Joe Perches
2011-11-30 2:14 ` [PATCH 03/28] bio: " Joe Perches
2011-11-30 2:14 ` [PATCH 04/28] libfs: " Joe Perches
2011-11-30 2:14 ` [PATCH 05/28] super: " Joe Perches
2011-11-30 2:14 ` [PATCH 06/28] exec: Use current logging style Joe Perches
2011-11-30 2:14 ` [PATCH 07/28] namespace: Use current logging styles Joe Perches
2011-11-30 2:14 ` [PATCH 08/28] block_dev: Use current logging style Joe Perches
2011-11-30 2:14 ` [PATCH 09/28] dcache: " Joe Perches
2011-11-30 2:14 ` [PATCH 10/28] fcntl: " Joe Perches
2011-11-30 2:14 ` [PATCH 11/28] file: " Joe Perches
2011-11-30 2:14 ` [PATCH 12/28] locks: " Joe Perches
2011-11-30 2:14 ` [PATCH 13/28] open: " Joe Perches
2011-11-30 2:14 ` [PATCH 14/28] stat: " Joe Perches
2011-11-30 2:14 ` [PATCH 15/28] exec: checkpatch wanking Joe Perches
2011-11-30 2:14 ` [PATCH 16/28] namespace: " Joe Perches
2011-11-30 2:22 ` Al Viro [this message]
2011-11-30 3:39 ` Joe Perches
2011-11-30 6:50 ` Al Viro
2011-11-30 8:34 ` Joe Perches
2011-11-30 2:14 ` [PATCH 17/28] block_dev: " Joe Perches
2011-11-30 2:14 ` [PATCH 18/28] dcache: " Joe Perches
2011-11-30 2:14 ` [PATCH 19/28] fcntl: " Joe Perches
2011-11-30 2:14 ` [PATCH 20/28] file: " Joe Perches
2011-11-30 2:14 ` [PATCH 21/28] locks: " Joe Perches
2011-11-30 2:14 ` [PATCH 22/28] open: " Joe Perches
2011-11-30 2:14 ` [PATCH 23/28] stat: " Joe Perches
2011-11-30 2:14 ` [PATCH 24/28] super: " Joe Perches
2011-11-30 2:14 ` [PATCH 25/28] libfs: " Joe Perches
2011-11-30 2:14 ` [PATCH 26/28] bio: " Joe Perches
2011-11-30 2:14 ` [PATCH 27/28] mbcache: " Joe Perches
2011-11-30 2:14 ` [PATCH 28/28] buffer: " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111130022245.GS2203@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=joe@perches.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.