From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: sh2a: Optimise cache flush for writethrough mode.
Date: Wed, 30 Nov 2011 09:17:03 +0000 [thread overview]
Message-ID: <20111130091703.GA9264@linux-sh.org> (raw)
In-Reply-To: <1322637713-15227-1-git-send-email-phil.edworthy@renesas.com>
On Wed, Nov 30, 2011 at 07:21:53AM +0000, Phil Edworthy wrote:
> When the operand cache is set to writethough mode, there is no
> need to flush data.
>
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
What about the other routines?
You are presumably stipulating that any access to the OC address array
outside of cacheline invalidation should be omitted for write-through
cache mode, which suggests that quite a lot of the file in question can
simply be nopped out.
At the very least sh2a__flush_wback_region() could deal with the same
treatment. For the invalidation routines you presumably still need the
V-bit clearing, though.
sh2a__flush_invalidate_region() also bears closer inspection.
next prev parent reply other threads:[~2011-11-30 9:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 7:21 [PATCH] sh: sh2a: Optimise cache flush for writethrough mode Phil Edworthy
2011-11-30 9:17 ` Paul Mundt [this message]
2011-11-30 9:56 ` phil.edworthy
2011-12-02 6:03 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111130091703.GA9264@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.