All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinicius Costa Gomes <vinicius.gomes@openbossa.org>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 4/4] Bluetooth: use buffer priority to mark URB_ISO_ASAP flag
Date: Wed, 30 Nov 2011 14:24:28 -0300	[thread overview]
Message-ID: <20111130172428.GA9425@samus> (raw)
In-Reply-To: <1320241924-2300-4-git-send-email-luiz.dentz@gmail.com>

Hi,

On 15:52 Wed 02 Nov, Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> ---
>  drivers/bluetooth/btusb.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index abfc4ee..9db2476 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -727,6 +727,9 @@ static int btusb_send_frame(struct sk_buff *skb)
>  		usb_fill_bulk_urb(urb, data->udev, pipe,
>  				skb->data, skb->len, btusb_tx_complete, skb);
>  
> +		if (skb->priority >= HCI_PRIO_MAX - 1)
> +			urb->transfer_flags  = URB_ISO_ASAP;
> +

In case someone is having problems:

With CONFIG_USB_DEBUG enabled the check that the URB_ISO_ASAP flag is
not valid for bulk endpoints is enabled, and that urb is rejected.

>  		hdev->stat.acl_tx++;
>  		break;
>  
> -- 
> 1.7.6.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


Cheers,
-- 
Vinicius

  parent reply	other threads:[~2011-11-30 17:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-02 13:52 [PATCH 1/4] Bluetooth: prioritizing data over HCI Luiz Augusto von Dentz
2011-11-02 13:52 ` [PATCH 2/4] Bluetooth: handle priority change within quote Luiz Augusto von Dentz
2011-11-02 13:52 ` [PATCH 3/4] Bluetooth: recalculate priorities when channels are starving Luiz Augusto von Dentz
2011-11-02 13:52 ` [PATCH 4/4] Bluetooth: use buffer priority to mark URB_ISO_ASAP flag Luiz Augusto von Dentz
2011-11-03 14:25   ` Gustavo Padovan
2011-11-30 17:24   ` Vinicius Costa Gomes [this message]
2011-12-01  7:23     ` Luiz Augusto von Dentz
2011-12-02 12:25       ` Gustavo Padovan
2011-12-22  1:07         ` Vinicius Costa Gomes
2011-11-02 14:22 ` [PATCH 1/4] Bluetooth: prioritizing data over HCI Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111130172428.GA9425@samus \
    --to=vinicius.gomes@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.