From: James Hogan <james@albanarts.com>
To: Shashidhar Hiremath <shashidharh@vayavyalabs.com>
Cc: James Hogan <james.hogan@imgtec.com>, Chris Ball <cjb@laptop.org>,
Shawn Guo <shawn.guo@linaro.org>,
Philip Rakity <prakity@marvell.com>,
"Mark F. Brown" <mark.brown314@gmail.com>,
Wolfram Sang <w.sang@pengutronix.de>,
Will Newton <will.newton@imgtec.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH 1/1] mmc:Support of PCI mode for the dw_mmc driver
Date: Wed, 30 Nov 2011 21:49:50 +0000 [thread overview]
Message-ID: <20111130214950.GA25968@balrog> (raw)
In-Reply-To: <CANYdXnqgnvf5XnQ=dcuAu7C2WBNTMjJODqsgYB807OPTtROF+A@mail.gmail.com>
On Wed, Nov 30, 2011 at 11:50:31PM +0530, Shashidhar Hiremath wrote:
> Hi James,
> For some reason I was unable to reproduce the errors during compilation.
> Can you send me one instance of the error ?
CC [M] drivers/mmc/host/dw_mmc.o
drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_start_command’:
drivers/mmc/host/dw_mmc.c:272:2: warning: passing argument 2 of ‘dev_printk’ from incompatible pointer type [enabled by default]
include/linux/device.h:788:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_submit_data_dma’:
drivers/mmc/host/dw_mmc.c:466:2: warning: passing argument 1 of ‘dma_map_sg_attrs’ from incompatible pointer type [enabled by default]
include/asm-generic/dma-mapping-common.h:41:19: note: expected ‘struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:469:2: warning: passing argument 2 of ‘dev_printk’ from incompatible pointer type [enabled by default]
include/linux/device.h:788:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_request_end’:
drivers/mmc/host/dw_mmc.c:807:3: warning: passing argument 2 of ‘dev_printk’ from incompatible pointer type [enabled by default]
include/linux/device.h:788:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:812:3: warning: passing argument 2 of ‘dev_printk’ from incompatible pointer type [enabled by default]
include/linux/device.h:788:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_tasklet_func’:
drivers/mmc/host/dw_mmc.c:947:7: warning: passing argument 1 of ‘dev_err’ from incompatible pointer type [enabled by default]
include/linux/device.h:797:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_init_slot’:
drivers/mmc/host/dw_mmc.c:1654:37: warning: passing argument 2 of ‘mmc_alloc_host’ from incompatible pointer type [enabled by default]
include/linux/mmc/host.h:333:25: note: expected ‘struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_init_dma’:
drivers/mmc/host/dw_mmc.c:1761:8: warning: passing argument 1 of ‘dma_alloc_coherent’ from incompatible pointer type [enabled by default]
/home/james/src/kernel/linux/arch/x86/include/asm/dma-mapping.h:115:1: note: expected ‘struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:1764:4: warning: passing argument 1 of ‘dev_err’ from incompatible pointer type [enabled by default]
include/linux/device.h:797:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:1780:5: warning: passing argument 1 of ‘dev_err’ from incompatible pointer type [enabled by default]
include/linux/device.h:797:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:1784:3: warning: passing argument 1 of ‘dev_err’ from incompatible pointer type [enabled by default]
include/linux/device.h:797:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:1792:2: warning: passing argument 1 of ‘_dev_info’ from incompatible pointer type [enabled by default]
include/linux/device.h:803:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_probe’:
drivers/mmc/host/dw_mmc.c:1825:4: warning: passing argument 1 of ‘dev_err’ from incompatible pointer type [enabled by default]
include/linux/device.h:797:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:1831:4: warning: passing argument 1 of ‘dev_err’ from incompatible pointer type [enabled by default]
include/linux/device.h:797:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:1837:4: warning: passing argument 1 of ‘dev_err’ from incompatible pointer type [enabled by default]
include/linux/device.h:797:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:1878:2: warning: passing argument 1 of ‘mci_wait_reset’ from incompatible pointer type [enabled by default]
drivers/mmc/host/dw_mmc.c:1797:13: note: expected ‘struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:1921:24: error: ‘struct dw_mci’ has no member named ‘irq’
drivers/mmc/host/dw_mmc.c:1944:2: error: ‘pdev’ undeclared (first use in this function)
drivers/mmc/host/dw_mmc.c:1944:2: note: each undeclared identifier is reported only once for each function it appears in
drivers/mmc/host/dw_mmc.c:1961:2: error: ‘struct dw_mci’ has no member named ‘irq’
drivers/mmc/host/dw_mmc.c:1961:2: warning: passing argument 1 of ‘_dev_info’ from incompatible pointer type [enabled by default]
include/linux/device.h:803:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:1966:3: warning: passing argument 1 of ‘_dev_info’ from incompatible pointer type [enabled by default]
include/linux/device.h:803:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:1977:15: error: ‘struct dw_mci’ has no member named ‘irq’
drivers/mmc/host/dw_mmc.c:1986:6: warning: passing argument 1 of ‘dma_free_coherent’ from incompatible pointer type [enabled by default]
/home/james/src/kernel/linux/arch/x86/include/asm/dma-mapping.h:142:20: note: expected ‘struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_remove’:
drivers/mmc/host/dw_mmc.c:2004:3: warning: passing argument 2 of ‘dev_printk’ from incompatible pointer type [enabled by default]
include/linux/device.h:788:12: note: expected ‘const struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c:2013:15: error: ‘struct dw_mci’ has no member named ‘irq’
drivers/mmc/host/dw_mmc.c:2015:2: warning: passing argument 1 of ‘dma_free_coherent’ from incompatible pointer type [enabled by default]
/home/james/src/kernel/linux/arch/x86/include/asm/dma-mapping.h:142:20: note: expected ‘struct device *’ but argument is of type ‘struct device **’
drivers/mmc/host/dw_mmc.c: In function ‘dw_mci_resume’:
drivers/mmc/host/dw_mmc.c:2069:2: warning: passing argument 1 of ‘mci_wait_reset’ from incompatible pointer type [enabled by default]
drivers/mmc/host/dw_mmc.c:1797:13: note: expected ‘struct device *’ but argument is of type ‘struct device **’
>
> On Wed, Nov 30, 2011 at 9:31 PM, Shashidhar Hiremath
> <shashidharh@vayavyalabs.com> wrote:
> > On Wed, Nov 30, 2011 at 9:11 PM, James Hogan <james.hogan@imgtec.com> wrote:
> >> Hi,
> >>
> >> On 11/30/2011 03:27 PM, Shashidhar Hiremath wrote:
> >>> Hi James,
> >>> Sorry for the minor alignment issues.Will fix them .
> >>
> >> Thanks
> >>
> >>> I actually did
> >>> compile the code but as separate driver not along with the kernel. In
> >>> fact, I have also tested the PCI patch ,but not as separate files but
> >>> with the earlier #ifdef method I had sent in initial patch .
> >>
> >> But the new patch was completely different, you can't just rework the
> >> entire patch and expect it to compile and work without at least trying
> >> it to make sure, as evidenced by the fact that with mmc_next + your
> >> patch, I get:
> >> dw_mmc.c: 7 errors, 22 warnings
> >> dw_mmc-pci.c: 2 errors
> >> dw_mmc-pltfm.c: 6 errors, 1 warning
> >>
> > ohh,
> > will compile and fix it
> >> Cheers
> >> James
> >>
> >>> On Wed, Nov 30, 2011 at 7:36 PM, James Hogan <james.hogan@imgtec.com> wrote:
> >>>> *sigh* You haven't actually tried compiling this have you? How do you
> >>>> know whether it works or not? You really really should at least make
> >>>> sure it compiles (for simple changes) and works without breaking
> >>>> anything (for anything non-trivial like adding support for a new bus
> >>>> like PCI)!
> >>
> >>
> >
> >
> >
> > --
> > regards,
> > Shashidhar Hiremath
>
>
>
> --
> regards,
> Shashidhar Hiremath
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-11-30 21:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 12:36 [PATCH 1/1] mmc:Support of PCI mode for the dw_mmc driver Shashidhar Hiremath
2011-11-30 14:06 ` James Hogan
2011-11-30 15:27 ` Shashidhar Hiremath
2011-11-30 15:41 ` James Hogan
2011-11-30 16:01 ` Shashidhar Hiremath
2011-11-30 18:20 ` Shashidhar Hiremath
2011-11-30 21:49 ` James Hogan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111130214950.GA25968@balrog \
--to=james@albanarts.com \
--cc=cjb@laptop.org \
--cc=james.hogan@imgtec.com \
--cc=jh80.chung@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.brown314@gmail.com \
--cc=prakity@marvell.com \
--cc=shashidharh@vayavyalabs.com \
--cc=shawn.guo@linaro.org \
--cc=w.sang@pengutronix.de \
--cc=will.newton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.