From: Alessandro Rubini <rubini@gnudd.com>
To: rusty@ozlabs.org
Cc: greg@kroah.com, linux-kernel@vger.kernel.org, siglesia@cern.ch,
manohar.vanga@cern.ch
Subject: Re: [RGC PATCH 0/2] split file2alias using elf sections
Date: Thu, 1 Dec 2011 01:53:42 +0100 [thread overview]
Message-ID: <20111201005342.GA16378@mail.gnudd.com> (raw)
In-Reply-To: <87k46itcvg.fsf@rustcorp.com.au>
Hello Rusty, thankyou for your feedback.
I plan to make V2 tomorrow (it was planned much earlier).
> The table driven loop is nice and simple, though the E() macro is a bit
> contrived.
Yes, but we have long names and I wanted to avoid splitting lines.
I can make it ENTRY().
> The separation into separate files just to avoid merge issues is
> overkill and useless churn. The conflicts are simple, and you've just
> moved themto conflicts in the Makefile.
Yes and no. Actually, I expect several new buses to appear over time,
and being separate files they can even be conditionally compiled based
on config.
> We'd be better off putting the table in alphabetical order and stopping
> there. Easy code, no tricks.
I see. I'm submitting two patches anyways, but you can pick one only.
Thanks
/alessandro
prev parent reply other threads:[~2011-12-01 0:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-04 12:23 [RGC PATCH 0/2] split file2alias using elf sections Alessandro Rubini
2011-11-04 12:23 ` [RFC PATCH 1/2] modpost: use table-lookup to build module aliases Alessandro Rubini
2011-11-04 12:23 ` [RFC PATCH 2/2] modpost: use config and ELF sections to build file2alias Alessandro Rubini
2011-11-23 16:28 ` Dave Martin
2011-11-23 16:28 ` Dave Martin
2011-11-23 16:54 ` Alessandro Rubini
2011-11-23 16:54 ` Alessandro Rubini
2011-11-23 17:14 ` Dave Martin
2011-11-23 17:14 ` Dave Martin
2011-11-22 19:23 ` [RGC PATCH 0/2] split file2alias using elf sections Greg KH
2011-11-22 19:56 ` Alessandro Rubini
2011-11-30 5:09 ` Rusty Russell
2011-12-01 0:53 ` Alessandro Rubini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111201005342.GA16378@mail.gnudd.com \
--to=rubini@gnudd.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manohar.vanga@cern.ch \
--cc=rusty@ozlabs.org \
--cc=siglesia@cern.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.