From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] image: Don't detect XIP images as overlapping.
Date: Thu, 1 Dec 2011 09:57:38 +0100 [thread overview]
Message-ID: <201112010957.38935.sr@denx.de> (raw)
In-Reply-To: <1320956274-16597-2-git-send-email-swarren@nvidia.com>
On Thursday 10 November 2011 21:17:54 Stephen Warren wrote:
> bootm_load_os() detects when it writes the decompressed image over
> the top of the compressed image. If this happens, the original image
> is corrupted. When the original image is a multi-component legacy image,
> or a (potentially multi-component) FIT image, this implies that other
> components may be corrupted. In turn, this means that booting is unlikely
> to be successful.
>
> However, in the case of no image compresssion coupled with an image with
> load address equal to where the image is already located (e.g. an XIP
> kernel, or IH_TYPE_KERNEL_ANYLOAD), there has been no copy and hence no
> corruption, no matter whether it's a single-component legacy image, a
> multi-component legacy image, or a FIT image. In this case, disable the
> overlap detection, and allow boot to continue.
>
> Without this change, when booting a single-component legacy image that
> contains an IH_TYPE_KERNEL_ANYLOAD, bootm_load_os() would have returned
> BOOTM_ERR_OVERLAP, but the caller ignores this, and boot continues and
> succeeds. Now, the false error is no longer even returned.
>
> Without this change, when booting a FIT image that contains an
> IH_TYPE_KERNEL_ANYLOAD, bootm_load_os() would have returned
> BOOTM_ERR_OVERLAP, which would then cause the caller to reset the board.
> Now, the false error is no longer returned, and boot succeeds.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
Applied (after fixing a small merge conflict) to u-boot-staging/sr at denx.de.
Thanks.
Best regards,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
next prev parent reply other threads:[~2011-12-01 8:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 20:17 [U-Boot] [PATCH 1/2] image: Implement IH_TYPE_KERNEL_NOLOAD Stephen Warren
2011-11-10 20:17 ` [U-Boot] [PATCH 2/2] image: Don't detect XIP images as overlapping Stephen Warren
2011-12-01 8:57 ` Stefan Roese [this message]
2011-11-30 21:10 ` [U-Boot] [PATCH 1/2] image: Implement IH_TYPE_KERNEL_NOLOAD Stephen Warren
2011-11-30 22:54 ` Wolfgang Denk
2011-12-01 8:56 ` Stefan Roese
-- strict thread matches above, loose matches on Subject: below --
2011-11-09 17:47 [U-Boot] [PATCH 1/2] image: Implement IH_TYPE_KERNEL_ANYLOAD Stephen Warren
2011-11-09 17:47 ` [U-Boot] [PATCH 2/2] image: Don't detect XIP images as overlapping Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112010957.38935.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.